T09 · Insecure Skill Coding Practices
- Location
watchdog.py:171- Finding
TLS Certificate Validation Is Explicitly Disabled
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This monitoring skill mostly matches its stated purpose, but it asks for broad OpenClaw capabilities and its HTTPS/SSL checks are unsafe enough to give false health results.
Review before installing. Use it only if you are comfortable granting broad monitoring-related capabilities, and do not rely on its HTTPS or SSL-expiry results until certificate validation and expiry parsing are fixed. Prefer a version with narrower manifest permissions and explicit user control for any alerts or scheduled checks.
watchdog.py:171TLS Certificate Validation Is Explicitly Disabled
skill.json:14Skill Manifest Requests Capabilities Beyond Implemented Requirements
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
infra-watchdog add-monitor
--type http
--name "Main API"
--url https://api.example.com/health
--expected-status 200
--timeout 5
subprocess module calls execute external commands. Without careful input validation, this enables command injection.
def check_docker(self, container_id: str) -> Tuple[str, float, str]:
"""Check Docker container status. Returns (status, 0, details)."""
try:
result = subprocess.run(
['docker', 'inspect', container_id],
capture_output=True,
text=True,
subprocess module calls execute external commands. Without careful input validation, this enables command injection.
def check_disk(self, mount_point: str = '/') -> Tuple[str, float, str]:
"""Check disk usage. Returns (status, 0, details)."""
try:
result = subprocess.run(
['df', '-h', mount_point],
capture_output=True,
text=True,
subprocess module calls execute external commands. Without careful input validation, this enables command injection.
def check_memory(self) -> Tuple[str, float, str]:
"""Check memory usage. Returns (status, 0, details)."""
try:
result = subprocess.run(
['free', '-b'],
capture_output=True,
text=True,
The SSL expiry check disables certificate verification and hostname checking, then reports only a generic 'Certificate valid' message without actually parsing and evaluating the certificate's expiration date. This can cause false assurance: expired, spoofed, or otherwise invalid certificates may be treated as healthy, undermining monitoring and delaying detection of certificate failures or MITM conditions.
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
def cmd_cron_install(args):
"""Install cron job for periodic checks."""
config = load_config()
interval = config.get('check_interval_minutes', 5)
This code creates a persistent data directory in the user's home workspace, and later stores configuration and monitoring results in local files and a SQLite database. While some success messages are printed, there is no explicit disclosure that the skill persistently records monitor targets and check history on disk, which is relevant to user data handling.
The skill actively sends HTTP requests to user-specified targets and opens TCP connections to remote hosts as part of monitoring. Although this behavior is central to the skill's purpose, the code does not clearly warn users during setup or command execution that endpoint information and connection metadata will be transmitted to those remote systems.
No suspicious patterns detected.