T09 · Insecure Skill Coding Practices
- Location
SKILL.md:39- Finding
Arbitrary Shell Command Execution from Untrusted Acceptance Checklists
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is an acceptance-test runner, but it lets checklist text drive Bash commands and automatic code/config changes with too little scoping or user approval.
Install only if you fully trust the workspace and every spec-human-verify.md file it may read. Before running it, review all backticked commands, avoid custom or external checklist paths, and do not allow it to modify .env, source code, or configuration unless you explicitly approve the exact changes.
SKILL.md:39Arbitrary Shell Command Execution from Untrusted Acceptance Checklists
The explicit instruction to inspect failures and automatically append missing variables to .env creates a credential-handling risk around secret-bearing configuration files. Even without direct exfiltration logic, autonomous reads/writes to .env can expose, overwrite, fabricate, or mishandle sensitive values, and the danger is elevated because acceptance execution does not require secret-management privileges.
2. 通过 Bash 执行
3. 成功 → 显示 `✓ [description]`,继续下一个项目
4. 失败 → 分析输出并尝试修复简单问题:
- .env 缺失变量 → 自动追加该变量
- 编译错误 → 显示错误,尝试修复,重新编译
- 版本不匹配 → 报告实际版本,`AskUserQuestion`:「继续」/「中止」
5. 修复后重试,最多 **3 轮**
The skill is framed as an acceptance-execution workflow, but it authorizes the agent to modify environment files, repair build/configuration issues, and retry autonomously. That materially expands privilege from verification into unsupervised remediation, creating risk of unintended code/config changes and unsafe command-side effects during what users may expect to be a read-mostly validation task.
Automatically appending missing variables to .env and attempting configuration/code fixes is not necessary for a pure acceptance-runner and violates least privilege. In practice, this can alter runtime behavior, corrupt local developer settings, or accidentally inject placeholder secrets/configuration into sensitive files without adequate validation.
For human-verification steps, the skill directs the AI to take a free-form user defect report and then directly 'fix code' in a loop until the user says the issue is resolved. This turns a human-oracle verification phase into an open-ended code-editing workflow driven by ambiguous natural-language feedback, which can introduce unsafe, unreviewed changes and exceed the skill's stated purpose.
The rule 所有用户-facing 信息用中文 mandates a single language for user-visible interactions. This is a natural-language locale policy constraint with no opt-in, fallback, or justification that the skill is region-specific.