T09 · Insecure Skill Coding Practices
- Location
geo_push_ops.py:247- Finding
Hard-Coded Feishu Webhook Secret Causes Undisclosed Message Disclosure
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is mostly a Feishu notification helper, but it contains an undisclosed hardcoded webhook that can send messages to a fixed external destination when no configuration is provided.
Review this skill before installing. Use it only after removing or rotating the embedded Feishu webhook, requiring explicit webhook configuration, and validating that outbound destinations are limited to the intended Feishu endpoint. Treat any message passed to it as potentially sent outside your environment.
geo_push_ops.py:247Hard-Coded Feishu Webhook Secret Causes Undisclosed Message Disclosure
geo_push_ops.py:266Unvalidated Caller-Controlled Webhook Enables Server-Side Request Forgery
The natural-language description is written as an instruction/specification entirely in Chinese, with no indication that users may choose another language or that the skill is limited to a Chinese-only regulatory or regional context. Under the policy, forcing a specific language without user opt-in is a locale/language policy violation.
The module docstring describes the skill as handling Feishu push operations, implying a delivery-focused utility. However, substantial code implements domain-specific alerting behavior such as high-priority determination, market watch thresholds, bias text selection, and geopolitical/market message composition in lines L90-L230, which goes beyond pure push operations.
The code embeds a live Feishu webhook URL and uses it as the default outbound destination, causing any caller of send_to_feishu() without explicit configuration to transmit message content to an external service. Hardcoded secrets/endpoints are dangerous because they can be abused by anyone with code access, enable unauthorized data exfiltration, and make accidental production notification leakage far more likely in a reusable skill context.
The function performs outbound HTTP transmission of message content to a webhook using requests.post(). In this skill, external transmission is expected behavior, but it becomes security-relevant because message content may contain sensitive operational or market information and is sent to a remote endpoint with limited guardrails; combined with the default hardcoded webhook, the risk is elevated.
start_time = time.time()
try:
resp = requests.post(config.webhook, json=payload, headers=headers, timeout=10)
result.http_status = resp.status_code
result.duration_ms = int((time.time() - start_time) * 1000)
The file's module description and all user-facing output strings are written in Chinese, which effectively imposes a specific language on users. There is no indication that the skill is region-specific or that users can opt into a different language/locale.