Security audit
Security checks for vulnerabilities and agentic risk
ClawScan marked this skill suspicious because scanners found risks around running helper commands and reporting incomplete clash checks as complete.
Review the skill's tool requirements and how its helper scripts are run before installing. If you use it for clash checking, verify that wall and opening extraction completed and review the results rather than relying on a completed status alone.
Without declared permissions the skill's intent is opaque and cannot be validated.
subprocess module calls execute external commands. Without careful input validation, this enables command injection.
workdir.mkdir(parents=True, exist_ok=True)
stem = input_path.stem
detail = workdir / f"{stem}.detail.json"
r = subprocess.run(
[sys.executable, str(cfr / "cad_scan.py"), str(input_path),
"--detail-json", str(detail), "--with-geom", "--with-geom-layer",
"--format", "json", "-o", str(workdir / f"{stem}_scan")],
Data from a source is assigned to a variable that is later passed to a sink, creating a variable-mediated taint flow.
workdir.mkdir(parents=True, exist_ok=True)
stem = input_path.stem
detail = workdir / f"{stem}.detail.json"
r = subprocess.run(
[sys.executable, str(cfr / "cad_scan.py"), str(input_path),
"--detail-json", str(detail), "--with-geom", "--with-geom-layer",
"--format", "json", "-o", str(workdir / f"{stem}_scan")],
subprocess module calls execute external commands. Without careful input validation, this enables command injection.
cmd = [sys.executable, str(script), str(detail), "--out-dir", str(geo_dir)]
if spec == "建筑":
cmd += ["--cfr", str(cfr)]
r = subprocess.run(cmd, capture_output=True, text=True, timeout=1800)
out = geo_dir / f"{detail.stem}.{cfg['suffix']}.json"
tail = (r.stderr or "").strip()[-300:] or (r.stdout or "").strip()[-200:]
if r.returncode != 0 or not out.exists():
Data from a source is assigned to a variable that is later passed to a sink, creating a variable-mediated taint flow.
cmd = [sys.executable, str(script), str(detail), "--out-dir", str(geo_dir)]
if spec == "建筑":
cmd += ["--cfr", str(cfr)]
r = subprocess.run(cmd, capture_output=True, text=True, timeout=1800)
out = geo_dir / f"{detail.stem}.{cfg['suffix']}.json"
tail = (r.stderr or "").strip()[-300:] or (r.stdout or "").strip()[-200:]
if r.returncode != 0 or not out.exists():
The main pipeline does not propagate missing wall/opening extraction warnings into its final report or completion status, and it unconditionally records status as done. Missing walls can therefore produce an apparently completed check with omitted collision candidates; the construction-review context makes this consequential, although the explicit human-review disclaimer limits reliance.
When --cfr is omitted, Path(args.cfr or "").resolve() selects the current working directory, which ordinarily passes the directory check and bypasses trusted dependency discovery. Running this helper from an untrusted project containing a malicious cad_structural_geometry.py or cad_deep_geometry.py executes that file with the user's privileges; the parent workflow's explicit --cfr argument reduces exposure but does not fix standalone use.
def run(cmd: list[str], what: str, timeout: int = 1800) -> None:
r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout)
if r.returncode != 0:
raise RuntimeError(f"{what}失败 rc={r.returncode}: {(r.stderr or r.stdout or '')[-400:]}")