T09 · Insecure Skill Coding Practices
- Location
scripts/download.py:112- Finding
Unvalidated Resolution Allows Directory Creation Outside the Intended Save Location
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This wallpaper downloader mostly does what it says, but its filesystem handling is broader than advertised and should be reviewed before installation.
Install only if you are comfortable with a script that downloads many images from the internet and writes them under your home directory. Use only the documented resolution values, avoid --no-skip unless you trust the destination directory contents, and check whether files are saved under ~/Pictures rather than the Chinese path shown in the description.
scripts/download.py:112Unvalidated Resolution Allows Directory Creation Outside the Intended Save Location
scripts/download.py:69Symlink Following Can Overwrite User-Writable Files During Downloads
The metadata says files are saved under ~/图片/{分辨率}/, while the body later states ~/Pictures/{分辨率}/. This inconsistency can mislead users about where data will be written, reducing transparency and potentially causing unintended storage use or difficulty auditing what the skill changed.
The skill performs network access and filesystem reads/writes but does not declare any tool scope or permissions boundary. In an agent environment, missing explicit capability declarations can cause users or orchestrators to invoke a skill without understanding that it will download remote content and write large amounts of data locally.
The trigger conditions include broad intents like wanting to 'organize wallpapers' or 'batch download images', which could cause the skill to be selected in contexts where the user did not specifically ask to fetch large volumes of content from this site. Over-broad routing increases the chance of unexpected network activity and disk writes.
Although the document mentions image counts and sizes later, it lacks a prominent upfront warning that execution will perform large-scale network downloads and write potentially gigabytes of data to the local filesystem. In agent use, insufficient disclosure can lead to surprising resource consumption, bandwidth usage, and storage exhaustion.
The module docstring and CLI descriptions are entirely in Chinese, and the script does not offer any language or locale selection. This creates a natural-language policy concern because it imposes a specific language on all users without opt-in or documented justification.