T09 · Insecure Skill Coding Practices
- Location
SKILL.md:36- Finding
Configurable MCP endpoint can disclose API credentials and booking PII
- Content
View full analysis
","roomId":"","preBookParam":"","checkInDate":"","checkOutDate":"","roomCount":1,"roomGuests":[{"guests":[{"firstName":"","lastName":""}]}],"contactName":"","contactPhone":""}}}' ``` The same configurable destination is used by the search and hotel-detail requests at lines 62–101. ### Technical Analysis The Skill sends the `TUNIU_API_KEY` in an HTTP request header to the value of `TUNIU_MCP_URL`. For order creation, it also sends guest names, the contact name, phone number, travel dates, hotel and room identifiers, and booking parameters. The default destination is the official HTTPS Tuniu endpoint, and transmitting the booking information to that endpoint is necessary for the declared booking functionality. However, the optional endpoint override is not constrained by scheme, hostname, port, or path. It can therefore designate an unrelated HTTPS host, a plaintext HTTP endpoint, or a local network service. This behavior exceeds the minimum privileges required by the Skill: ordinary operation only requires access to the official Tuniu hotel endpoint. Pe ...[truncated 1359 chars]- Remediation
View remediation
