T05 · Unauthorized Access and Privilege Escalation
Error
- Location
uninstall.sh:5- Finding
Shared Parent-Directory Data Can Be Deleted During Uninstallation
- Content
View full analysis
"$BASE_DIR/.env" << 'EOF' # OpenAI API Configuration OPENAI_API_KEY=your-api-key-here # Optional proxy configuration # HTTP_PROXY= # HTTPS_PROXY= EOF fi # Create parent-level data directories mkdir -p "$BASE_DIR/.ai_meeting_backup" mkdir -p "$BASE_DIR/.ai_meeting_logs" ``` ```bash # uninstall.sh:5-16 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" BASE_DIR="$(dirname "$SCRIPT_DIR")" read -p "Delete configuration files and backup data? (y/N): " -n 1 -r echo if [[ $REPLY =~ ^[Yy]$ ]]; then rm -f "$BASE_DIR/.env" rm -rf "$BASE_DIR/.ai_meeting_backup" rm -rf "$BASE_DIR/.ai_meeting_logs" fi ``` ### Technical Analysis `SCRIPT_DIR` resolves to the skill package directory, while `BASE_DIR` is explicitly assigned its parent. As a result, installation and removal operations are performed outside the package's own directory. The parent may be a shared workspace containing configuration and data used by other skills. The uninstaller does not verify ownership, check whether the files were created by this package, or confirm that the resolved deletion targets remain within the skill directory. The `rm -rf` operations therefore cross the package's expected filesystem boundary. There is also a path inconsistency: `source/meeting_helper.py` loads `.env` from the skill root, while `install.sh` creates it in the parent directory. Consequently, the installer may create or interact with an unrelated parent-level `.env` without configuring the runtime correctly. ### Attack Path 1. The skill is installed in a shared ski ...[truncated 974 chars]- Remediation
View remediation
&2; exit 1 ;; esac ``` 4. Track files created by the installer in a package-local manifest. The uninstaller should only remove files known to have been created by this installation. 5. Never delete a pre-existing `.env`. If a configuration file already exists, preserve it or create a package-specific configuration file instead. 6. Add automated tests that install and uninstall the package in a temporary shared workspace and verify that sibling and parent files remain unchanged. ]]>