T09 · Insecure Skill Coding Practices
- Location
execution-loop/scripts/ralph-init.sh:11- Finding
Unvalidated session identifiers permit filesystem path traversal
- Content
View full analysis
[max-iterations] [original-task]}" MAX_ITERATIONS="${2:-50}" ORIGINAL_TASK="${3:-}" SESSION_DIR="${HOME}/.openclaw/shared-context/sessions/${SESSION_ID}" mkdir -p "$SESSION_DIR/handoffs" STATE_FILE="${SESSION_DIR}/ralph.json" ``` Representative code from `context-memory/scripts/compaction-extract.sh`: ```bash INPUT=$(head -c 20000) SESSION_ID=$(echo "$INPUT" | jq -r '.session_id // ""' 2>/dev/null) [ -z "$SESSION_ID" ] && SESSION_ID="${NC_SESSION:-}" [ -z "$SESSION_ID" ] && echo '{"continue":true}' && exit 0 SESSION_DIR="${SESSIONS_DIR}/${SESSION_ID}" HANDOFFS_DIR="${SESSION_DIR}/handoffs" STATE_FILE="${SESSION_DIR}/compaction-extract.json" mkdir -p "$HANDOFFS_DIR" ``` Representative code from `execution-loop/scripts/ralph-cancel.sh`: ```bash SESSION_ID="${1:?Usage: ralph-cancel.sh [reason]}" REASON="${2:-user_abort}" SESSION_DIR="${HOME}/.openclaw/shared-context/sessions/${SESSION_ID}" mkdir -p "$SESSION_DIR" NOW=$(date -u +%FT%TZ) EXPIRES=$(date -u -v+30S +%FT%TZ 2>/dev/null || date -u -d '+30 seconds' +%FT%TZ) CANCEL_FILE="${SESSION_DIR}/cancel.json" ``` ### Technical Analysis Multiple scripts accept a session identifier from hook JSON, the `NC_SESSION` environment variable, or a com ...[truncated 2734 chars]- Remediation
View remediation
