T09 · Insecure Skill Coding Practices
- Location
SKILL.md:566- Finding
Payment Creation Workflow Lacks Explicit Final User Authorization
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md:566-574andSKILL.md:585-590
Vulnerability Type: Missing explicit authorization before a financially sensitive operation
Risk Level: MediumVulnerable Code Snippet
markdown 6. **Confirm pricing** — `GET /searches/{search_id}/offers/{offer_id}/pricing` 7. **Handle expiry** — if 410, re-run search and start from step 3 8. **Collect traveller details** — warn about passport matching first 9. **Choose payment method** — crypto or card 10. **If crypto** — `GET /tokens`, present grouped by blockchain (prefer stablecoins), collect wallet address for refund 11. **Create payment** — `POST /payments` with `method` field 12. **Present payment instructions:** - Crypto: exact `amount_in_formatted` + token + `deposit_address` + refund wallet - Card: full untruncated `payment_url`markdown 7. **Confirm pricing** — immediately `GET .../rates/{rate_id}/pricing` when user picks a rate 8. **Handle expiry** — if 410, re-run search and start from step 3 9. **Collect traveller details** — warn about passport matching first 10. **Choose payment method** — crypto or card 11. **Create payment** — include `rate_id` in offer object, use `method` field 12. **Present payment instructions** (same as flight)Technical Analysis
The flight and stay booking workflows instruct the agent to retrieve pricing, collect traveler details, choose a payment method, and then invoke
POST /payments. They do not require a separate, explicit confirmation after the agent presents the final price and transaction details.The phrase “Confirm pricing” refers to requesting current pricing from the API, not obtaining informed authorization from the user. Consequently, the documented sequence permits payment and itinerary creation based on an earlier offer selection or an ambiguous conversational response.
This is particularly sensitive because the operation ha ...[truncated 2368 chars]
- Remediation
View remediation
Remediation Suggestions
Add a mandatory authorization checkpoint immediately before every
POST /paymentsrequest.The agent should present a final transaction summary containing:
- Selected flight offer or accommodation rate
- Origin, destination, and travel dates, where applicable
- Traveler names
- Exact total amount and currency from the latest pricing response
- Baggage, refund, change, and cancellation conditions
- Selected payment method
- For cryptocurrency payments, the exact asset, blockchain network, and refund wallet address
Require a new, unambiguous affirmative response such as “Confirm payment creation” after presenting that summary. Offer selection, provision of traveler details, or selection of a payment method must not be treated as final authorization.
The workflow should explicitly state:
markdown **Final authorization required:** Before calling `POST /payments`, display the refreshed price, selected offer, traveler details, material booking conditions, and payment method. Ask the user to explicitly confirm creation of the payment. Do not infer consent from an earlier offer selection or an ambiguous response.Additional hardening should include:
- Retrieve pricing again if the confirmation is delayed or the offer may have expired.
- Bind confirmation to the displayed
search_id,offer_idorrate_id, amount, currency, and payment method. - Invalidate confirmation if any material field changes.
- Mask unnecessary personal information in the confirmation summary.
- Validate cryptocurrency network and wallet compatibility before asking for authorization.
- Record that explicit confirmation was obtained before invoking the payment endpoint.
