T09 · Insecure Skill Coding Practices
- Location
scripts/quote.py:65- Finding
Authentication Token Cached Without Explicit Access Controls or Symlink Protection
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill does what it claims by fetching Quodd stock quotes, but users should understand that it sends Quodd credentials to Quodd and caches a short-lived token in a local plaintext file.
Install only if you are comfortable providing Quodd credentials through environment variables and storing a Quodd API token locally for up to 20 hours. On shared or less trusted systems, prefer using --no-cache or tightening permissions on ~/.openclaw/credentials and the token file.
scripts/quote.py:65Authentication Token Cached Without Explicit Access Controls or Symlink Protection
Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.
req = Request(TOKEN_URL, data=b"", headers=headers, method="POST")
try:
with urlopen(req, timeout=TIMEOUT_SECONDS) as response:
data = json.loads(response.read().decode("utf-8"))
return data.get("token")
except HTTPError as e:
Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.
req = Request(TOKEN_URL, data=b"", headers=headers, method="POST")
try:
with urlopen(req, timeout=TIMEOUT_SECONDS) as response:
data = json.loads(response.read().decode("utf-8"))
return data.get("token")
except HTTPError as e:
The skill declares access to environment variables and its documented behavior implies network access plus credential/token handling, but it does not declare an explicit tool scope such as permissions or allowed-tools. This weakens policy enforcement and reviewability because the runtime capabilities exceed what is transparently constrained in the manifest, increasing the chance of unintended secret access, file writes, or outbound requests.
The manifest description says to use the skill when the user asks for 'stock prices, quotes, market data, or ticker information.' Terms like 'market data' and 'ticker information' are broad and lack clear boundaries or exclusion conditions, which could cause the skill to trigger for general finance questions beyond real-time US equity quotes.
The skill persists a Quodd API token to a predictable file under the user's home directory without setting restrictive permissions or warning the user. On multi-user systems or misconfigured environments, another local process or user could read the token and use it to access the Quodd account until expiry.
No suspicious patterns detected.