Back to skill

Security audit

Douban Movie Movie Reviews API

Security checks for vulnerabilities and agentic risk

Overview

This is a narrow movie-review API connector, with the main risk being careful handling of the required JustOneAPI token.

Install only if you are comfortable giving this skill a JustOneAPI token and sending movie review requests to api.justoneapi.com. Prefer a narrowly scoped, revocable token, avoid sharing logs or screenshots of commands, and rotate the token if it may have appeared in process lists, shell history, or URL logs.

Vulnerability Patterns
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)

T09 · Insecure Skill Coding Practices

Warning
Location
bin/run.mjs:94
Finding

API Token Exposed Through Process Arguments and URL Query Parameters

Content
View full analysis
"}' ``` `bin/run.mjs:94-96` injects that token into the request parameters: ```js const params = parseParams(args.paramsJson); applyDefaults(operation, params); injectToken(operation, params, args.token); ``` `bin/run.mjs:113` sends the constructed URL to the external API: ```js response = await fetch(url, requestInit); ``` `bin/run.mjs:209-217` adds every query parameter—including the API token—to the URL: ```js function applyQueryParams(operation, params, url) { for (const parameter of operation.parameters.filter((item) => item.location === "query")) { const value = params[parameter.name]; if (value === undefined) { continue; } appendValue(url.searchParams, parameter.name, value); } } ``` The operation manifest defines `token` as a required query parameter. Consequently, this flow constructs a request resembling: ```text https://api.justoneapi.com/api/douban/get-movie-reviews/v1?token=SECRET&subjectId=... ``` ### Technical Analysis The token is exposed through two separate channels: 1. **Process argument exposure:** Supplying the token with `--token` places it in the process command line. Depending on operating-system configuration and execution environment, command lines can be visible through process inspection, shell history, audit telemetry, job runners, diagnostic tooling, or orchestration metadata. 2. **URL exposure:** The token is serialized into the URL query string. HTTPS protects the request in transit, but query strings ma ...[truncated 2293 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
Findings (7)

Credential Access

High
Category
Privilege Escalation
Confidence
91% confidence
Finding

This finding is substantiated by the manifest declaring an access token parameter that is later injected into outbound requests. In this skill context, the token is not merely mentioned in documentation; it is operationally handled as user-supplied credential material and transmitted in a less-safe way, increasing the chance of credential exposure and subsequent unauthorized API use.

Content

Scanner excerpt · bin/run.mjs (reported line 20)May include surrounding context.

js
"parameters": [
        {
          "defaultValue": null,
          "description": "Access token for this API service.",
          "enumValues": [],
          "location": "query",
          "name": "token",

Credential Access

High
Category
Privilege Escalation
Confidence
87% confidence
Finding

The skill explicitly requests an access token, which represents credential collection and transmission. In context this appears operational rather than malicious, but because the token is collected via a query parameter in an external API call, the credential-access pattern is security-relevant and increases the chance of secret exposure.

Content

Scanner excerpt · generated/operations.json (reported line 15)May include surrounding context.

json
"parameters": [
        {
          "defaultValue": null,
          "description": "Access token for this API service.",
          "enumValues": [],
          "location": "query",
          "name": "token",

Credential Access

High
Category
Privilege Escalation
Confidence
70% confidence
Finding

Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.

Content

Scanner excerpt · generated/operations.md (reported line 19)May include surrounding context.

md
| Name | In | Required | Type | Default | Description |
| --- | --- | --- | --- | --- | --- |
| `token` | `query` | yes | `string` | n/a | Access token for this API service. |
| `subjectId` | `query` | yes | `string` | n/a | The unique ID for a movie or TV subject on Douban. |
| `sort` | `query` | no | `string` | `time` | Sort order for the result set.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
88% confidence
Finding

The skill invokes a network-capable helper (node {baseDir}/bin/run.mjs) to call an external API, but the manifest does not declare any explicit tool scope such as permissions or allowed-tools. This creates a transparency and policy-enforcement gap: an agent or reviewer cannot reliably determine from the manifest alone that the skill will make outbound network requests and handle secrets, which can lead to unintended external data transmission.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The skill defines the API access token as a query parameter and automatically appends it to the request URL. Query-string secrets are commonly exposed in logs, browser/history artifacts, proxy caches, monitoring systems, and error messages, making accidental credential disclosure more likely even when HTTPS is used.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

Requiring the access token in a query parameter exposes credentials to leakage through logs, browser history, intermediary proxies, analytics systems, and referrer propagation. Even over HTTPS, query strings are commonly captured by application infrastructure, making this a real credential-handling weakness.

Content

No source excerpt is available for this finding.

Vague Triggers

Low
Category
Not specified by scanner
Confidence
86% confidence
Finding

This manifest-style file describes the API capability but does not specify concrete activation phrases, limiting conditions, or exclusion cases. Without narrow invocation guidance, an agent may infer broad use from generic movie-review requests and trigger the skill in unintended contexts.

Content

No source excerpt is available for this finding.

Static analysis

No suspicious patterns detected.