T09 · Insecure Skill Coding Practices
- Location
scripts/seasonal_planting.py:418- Finding
Unsafe Export Path Validation Allows Unauthorized File Overwrites
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The planting guide is purpose-aligned, but its export feature can overwrite broad home or temporary-directory paths despite stronger safety claims.
Install only if you are comfortable with a local gardening tool that writes a custom plant database and can export markdown files. Until fixed, avoid using --export with important existing files, dotfiles, or broad home-directory paths; prefer a dedicated new file under ~/.openclaw/workspace/.
scripts/seasonal_planting.py:418Unsafe Export Path Validation Allows Unauthorized File Overwrites
The top-level docstring frames the script as a guide that provides planting schedules, which implies an informational lookup tool. However, the implemented commands include mutating persistent state via add and writing user-chosen files via export_calendar, which are materially different side effects not reflected in that documentation.
This code file supports the add command, which persists user-supplied data to ~/.openclaw/workspace/planting_calendar.json via save_db, but the top-level usage text only describes the command and does not disclose that it writes to disk. Under the code-file warning rule, file writes should have some visible disclosure; the success print happens after the write and does not serve as advance notice.
No suspicious patterns detected.