T09 · Insecure Skill Coding Practices
- Location
idcard.py:25- Finding
Sensitive National ID Number and API Credential Transmitted in URL Query Parameters
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill appears purpose-built for ID-card lookup, but it sends sensitive national ID data and an API key to a third-party API without a clear privacy warning.
Review before installing. Use it only if users understand that ID-card queries may be sent to JisuAPI, avoid submitting full national ID numbers when a six-digit region code is enough, and treat the JISU_API_KEY as a secret that may appear in provider or proxy logs because the script sends it in URL parameters.
idcard.py:25Sensitive National ID Number and API Credential Transmitted in URL Query Parameters
Mixing characters from multiple Unicode scripts in a single identifier is a common technique to create visually ambiguous tool names.
The skill uses sensitive environment data and makes outbound API calls, but it does not declare an explicit tool scope such as permissions or allowed-tools. This weakens reviewability and sandbox policy enforcement, making it easier for a skill to access secrets and transmit user data to a third party without clear operator awareness.
This skill is designed to send Chinese national ID numbers to a third-party API, but the description does not warn users that highly sensitive personal data will leave the local system. Because ID card numbers directly encode identity attributes and can be used for profiling or misuse, silent transmission materially increases privacy and compliance risk.
This line defines an external endpoint used for ID card lookups, confirming outbound data transmission to a third-party service. External transmission is not automatically insecure, but in this skill it becomes security-relevant because the transmitted field is highly sensitive identity data and the remote processing is not clearly disclosed by the manifest.
import requests
IDCARD_QUERY_URL = "https://api.jisuapi.com/idcard/query"
CITY2CODE_URL = "https://api.jisuapi.com/idcard/city2code"
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
IDCARD_QUERY_URL = "https://api.jisuapi.com/idcard/query"
CITY2CODE_URL = "https://api.jisuapi.com/idcard/city2code"
def query_idcard(appkey: str, req: dict):
The implementation does not perform local parsing as described; instead, it acts mainly as a proxy to external endpoints. This is dangerous because users and platform operators may trust the skill under a false assumption that sensitive data is processed locally, leading to uninformed disclosure of personal information to a third party.
At line 37 the code sends the full ID card number to an external API without any in-skill warning, consent step, or privacy notice. Since ID card numbers are sensitive PII, transmitting them off-platform can expose users to privacy violations, regulatory issues, or unauthorized retention by the third-party provider.
The skill loads a secret API key from the environment and sends user-supplied ID card data to a third-party service, while the manifest describes the capability as local parsing/query behavior. Because Chinese ID card numbers are highly sensitive personal data containing region, birth date, and identity-linked information, this mismatch creates a meaningful privacy and data-handling risk through undisclosed external transmission.
The natural-language description and inline documentation are presented in Chinese only, with no indication that the skill is region-specific or that users may choose another language. This can violate language or locale policy when a skill imposes a language without opt-in or justification.
No suspicious patterns detected.