T08 · Insecure Dependencies
- Location
SKILL.md:65- Finding
Unpinned and Unnecessary Third-Party Dependencies
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill presents itself as a real Chinese securities trading integration, but the bundled implementation is a simulator that accepts broker credentials and returns fabricated trading results.
Review this carefully before installing. Treat it as simulation code only unless the publisher clearly documents and implements real broker authentication, paper/live separation, credential handling, order confirmation, risk limits, and authoritative broker reconciliation. Do not provide production broker credentials to this version.
SKILL.md:65Unpinned and Unnecessary Third-Party Dependencies
quant_trading.py:69Live Trading Functionality Is Misrepresented by a Mock Implementation
The documentation claims real broker integration, real-time data, and live order execution, but the analyzed behavior indicates mock or synthetic implementations instead of actual authenticated broker connectivity. In a financial-trading context, this is dangerous because users may make trading, risk, or deployment decisions based on false assumptions about execution, account state, and market data, potentially causing direct financial loss or unsafe automation.
The strategy code can place buy and sell orders automatically during runtime without any confirmation, approval gate, risk limit, or explicit dry-run safeguard. In a trading skill, this is especially dangerous because erroneous strategy logic, bad data, or misuse can trigger immediate financial transactions and losses.
The skill documents capabilities that inherently require network access and likely credentials handling, but it does not declare any explicit tool scope or permissions boundary. In an agent ecosystem, missing scope declarations can cause reviewers and users to underestimate what the skill may access, reducing transparency and increasing the chance of unsafe execution with network or environment data exposure.
The skill describes placing buy/sell orders and managing orders without an explicit warning that such actions may be irreversible and can affect real assets. In a trading context, omission of this warning increases the chance that users treat examples as safe defaults and trigger unintended financial transactions or losses.
The automated strategy, scheduled order, stop loss, and take profit sections encourage unattended execution without clearly warning that automation can trade continuously or at specific times without further review. In a financial system, unattended execution can amplify mistakes, strategy bugs, stale data issues, or misconfiguration into repeated asset-impacting actions.
The module description and class docstrings frame the skill as specifically for Chinese brokers, and the implementation hardcodes Chinese broker names, A-share trading hours, and Chinese stock labels. There is no natural-language indication that users can choose another locale or that the locale restriction is intentionally documented as a region-specific tool.
The code claims to be a mock implementation, but the constructor still ingests real broker credentials from environment variables. This can mislead users into providing production secrets to code they may assume is non-sensitive test code, increasing the risk of accidental credential exposure, misuse, or later extension into real networked behavior.
The manifest explicitly scopes broker support to 华泰, 银河, 广发, and 中信建投. The BROKERS table additionally declares 'tonghuashun' with a Tushare API endpoint, extending beyond the described broker set and mixing a market-data provider into broker integration scope.