T09 · Insecure Skill Coding Practices
- Location
scripts/generate_video.py:269- Finding
Unvalidated Server-Provided Video URL Enables Server-Side Request Forgery
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill matches its video-generation purpose, but it needs review because it sends prompts to an external provider and downloads provider-supplied URLs without strong network or size controls.
Install only if you are comfortable sending prompts to Alibaba Cloud DashScope and storing generated videos locally. Use a dedicated DashScope key with limited scope where possible, avoid secrets or sensitive personal data in prompts, set a controlled output directory, and review or patch the download code before using it in sensitive or shared environments.
scripts/generate_video.py:269Unvalidated Server-Provided Video URL Enables Server-Side Request Forgery
scripts/generate_video.py:160Unbounded Downloads and Missing Network Timeouts Allow Resource Exhaustion
Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.
}
}
response = requests.post(API_URL, headers=headers, json=payload)
if response.status_code != 200:
print(f"❌ 提交任务失败: {response.status_code}", file=sys.stderr)
Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.
"Authorization": f"Bearer {api_key}"
}
response = requests.get(f"{TASK_QUERY_URL}{task_id}", headers=headers)
if response.status_code != 200:
return None, f"查询失败: {response.status_code}"
The skill appears to use environment variables, network access to a cloud API, and shell/Python execution, but it does not declare any explicit tool scope or permissions. This weakens least-privilege controls and makes it easier for the skill to be invoked with broader capabilities than users or the platform may expect.
The activation guidance is broad enough to match many ordinary requests about videos or visualization, which can cause the skill to trigger in situations where the user did not intend to send content to an external service. In this context, over-triggering is more concerning because prompts may contain sensitive data and the skill produces files on disk.
The documentation does not warn that user prompts are transmitted to an external cloud video-generation provider and that generated outputs are persisted to local storage. This creates a privacy and data-handling risk because users may provide confidential prompts without understanding they will leave the local environment and create residual files.
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
}
}
response = requests.post(API_URL, headers=headers, json=payload)
if response.status_code != 200:
print(f"❌ 提交任务失败: {response.status_code}", file=sys.stderr)
The module docstring and all CLI help/messages are written in Chinese, which effectively constrains the skill's user-facing behavior to a specific language. The file does not offer any opt-in, locale selection, or documented justification for this language restriction.