T09 · Insecure Skill Coding Practices
- Location
scripts/skill-zip-audit.sh:28- Finding
Untrusted ZIP Archives Are Extracted into a Predictable Shared Temporary Directory
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill has a coherent security-auditing purpose, but its watcher runs hard-coded scripts outside the reviewed package and its ZIP handling is under-contained for untrusted archives.
Review before installing. Run only in an isolated workspace with disposable ZIP inputs, and do not use the watcher unless the hard-coded script paths are replaced with package-relative paths. Prefer a version that validates archive entries, uses mktemp with restrictive permissions, limits extraction size/count, and makes output paths configurable.
scripts/skill-zip-audit.sh:28Untrusted ZIP Archives Are Extracted into a Predictable Shared Temporary Directory
scripts/skill-zip-watch.sh:5Watcher Executes Hard-Coded Scripts Outside the Reviewed Package
Referenced artifact was not completely inspected
- `scripts/skill-zip-watch.sh`
Referenced artifact was not completely inspected
- `scripts/skill-zip-watch.sh`
Referenced artifact was not completely inspected
- `scripts/generate-skill-audit-pro.py`
The skill advertises and documents shell execution plus file read/write behavior, but it does not declare an explicit tool scope such as permissions or allowed-tools. That mismatch weakens trust boundaries and reviewability, because a user or platform may not be clearly informed that the skill can inspect ZIP contents, generate files, and move files on disk.
The documentation promotes a continuous watch mode that automatically sorts files into risk folders, but it does not prominently warn that user files will be moved as a side effect. This can cause unintended file manipulation, confusion, or operational disruption, especially if a user runs it on a broad or sensitive directory expecting read-only analysis.
The manifest describes auditing skill ZIPs, classifying risk, auto-sorting files, and generating a security dashboard. This script specifically writes the dashboard to a hard-coded local path on a particular user's Desktop, which is an additional concrete filesystem side effect not conveyed by the description and narrower than a generic dashboard-generation claim.
The script is configured to write output to /Users/gascomp/Desktop/skill-audit-pro.html, which is a file write affecting the local filesystem. In this file there is no confirmation prompt, user-facing log before the write, docstring, or comment explaining that behavior; the only print happens after the write completes.
The script scans /tmp/skill-audit/*/report.md and suspicious.txt files, which may contain user or system audit data. The code does not include any visible warning, docstring, or comment informing the user that local audit artifacts will be collected and incorporated into the generated report.