T08 · Insecure Dependencies
- Location
scripts/launcher.py:21- Finding
Unpinned Third-Party Skill Installation Allows Supply-Chain Code Execution
- Content
View full analysis
Vulnerability Details
File Location:
scripts/launcher.py:21-29; related installation instructions inreferences/core_logic.md:38-54and trust assertion inreferences/ui_templates.md:62-69
Vulnerability Type: Unverified and unpinned third-party dependency installation
Risk Level: HighVulnerable Code
scripts/launcher.py:21-29:python def install_skill(skill_name): """Install the specified skill.""" print(f"Installing {skill_name}...") # Install through the OpenClaw CLI cmd = f"openclaw skills install {skill_name}" try: subprocess.run(cmd, shell=True, check=True) return True except subprocess.CalledProcessError: return Falsereferences/core_logic.md:38-54:text Installation commands: Cultivation game: npx skills add cultivation-chronicle-cn -g -y or: openclaw skills install cultivation-chronicle-cn Wuxia game: npx skills add wuxia-quwen -g -y or: openclaw skills install wuxia-quwenreferences/ui_templates.md:62-69:text Package information: - Name: Cultivation Chronicle (cultivation-chronicle) - Type: Cultivation text adventure - Size: Approximately 2 MB - Source: skillhub (trusted) Install now? Reply "yes" to confirm.Technical Analysis
The Skill installs third-party packages by mutable package name without a pinned version, integrity hash, signature check, fixed registry URL, or publisher verification. The documented
npx ... -g -yalternative also performs unattended global installation and can execute package lifecycle code.The UI labels an unspecified SkillHub source as trusted, but the implementation does not authenticate that source or establish that the resolved package is the expected reviewed artifact. The package identifiers are also inconsistent: the UI refers to
cultivation-chronicle, while the implementation installscultivation-chronicle-cn. Th ...[truncated 1830 chars]- Remediation
View remediation
Remediation Suggestions
-
Pin every dependency to a specific reviewed version or immutable content digest.
-
Configure an explicit approved registry and verify publisher identity, package signatures, and cryptographic hashes before installation.
-
Remove the unattended global
npx ... -g -yinstallation path. -
Present the exact package name, version, publisher, source URL, permissions, and integrity digest before requesting installation approval.
-
Replace shell execution with an argument array:
python subprocess.run( ["openclaw", "skills", "install", verified_skill_name], check=True, shell=False, ) -
Enforce an internal allowlist mapping game identifiers to immutable package metadata rather than accepting arbitrary package names.
-
Install dependencies in a restricted environment with minimum filesystem and network privileges.
-
Reconcile the inconsistent
cultivation-chronicleandcultivation-chronicle-cnidentifiers. -
Do not describe a source as trusted unless the implementation performs corresponding authenticity and integrity checks.
-
