T09 · Insecure Skill Coding Practices
- Location
references/config-reference.md:49- Finding
Unnecessary Global Agent Model Configuration Exceeds the Skill's Functional Scope
- Content
View full analysis
Vulnerability Details
File Location:
references/config-reference.md, lines 49–60
Vulnerability Type: Unnecessarily broad modification of global Agent configuration
Risk Level: MediumVulnerable Configuration
json { "agents": { "defaults": { "model": { "primary": "minimax/MiniMax-M2.7" }, "memorySearch": { "provider": "ollama", "model": "nomic-embed-text:latest" }, "thinkingDefault": "high" } } }Technical Analysis
The Skill declares local memory management using Ollama for embeddings. Only the
memorySearchconfiguration is necessary for that functionality. However, the supplied configuration also changes the global primary language model tominimax/MiniMax-M2.7and sets the default reasoning level tohigh.These settings affect general Agent behavior rather than the memory subsystem and therefore exceed the minimum configuration privileges required by the Skill. If a user replaces or broadly merges their existing
openclaw.jsonwith this example, all subsequent Agent requests may use the unrelated primary model configuration.The actual network and data-handling behavior of the named model provider is not defined in this repository. Consequently, external transmission cannot be conclusively established from the audited files alone. Nevertheless, changing the global model may undermine the documented local-only expectation and can cause unintended processing, availability, privacy, or cost consequences depending on the user's installed provider configuration.
The separately flagged embedding request in
references/deployment.mdtargets the fixed loopback endpointhttp://localhost:11434/api/embeddings. Sending input text to that local Ollama endpoint is necessary to generate embeddings, and no external exfiltration endpoint, credential collection, or obfuscated payload was identified.Attack Path
- A user follows the configuration instructions ...[truncated 1331 chars]
- Remediation
View remediation
Remediation Suggestions
- Remove the unrelated
agents.defaults.model.primaryandthinkingDefaultfields from the memory configuration example. - Document only the minimum required configuration:
json { "agents": { "defaults": { "memorySearch": { "provider": "ollama", "model": "nomic-embed-text:latest" } } } }- Explicitly instruct users to merge only the
memorySearchobject into their existing configuration rather than replacing the completeagents.defaultsobject. - State that users should retain their existing primary model and reasoning settings unless they intentionally choose to change them.
- Add a warning that selecting a nonlocal primary model may transmit conversation content according to that provider's configuration and privacy policy.
- Recommend backing up
~/.openclaw/openclaw.jsonbefore modification and validating the effective configuration after the change.
- Remove the unrelated
