T09 · Insecure Skill Coding Practices
- Location
scripts/bnb_band_bot.py:46- Finding
Unnecessary Private-Key Loading in Placeholder and Dry-Run Modes
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This trading skill is not malicious, but it asks for a wallet private key even though the included bot only logs placeholder trades and lacks some documented safety checks.
Review this before installing if you would use a real wallet. Treat any private key placed in EVM_PRIVATE_KEY as highly sensitive, prefer a test or low-value wallet, and do not fund it until the placeholder trading, gas/balance checks, transaction signing path, limits, and confirmation behavior are clearly implemented and audited.
scripts/bnb_band_bot.py:46Unnecessary Private-Key Loading in Placeholder and Dry-Run Modes
The bot is structured to perform live trading when invoked with --mode run, but it provides no explicit confirmation prompt, prominent warning, or protective guardrails before entering a potentially irreversible trading loop. In an agent-skill context, this increases the chance of accidental fund-moving behavior if a user or orchestrator triggers live mode without understanding the financial risk.
The code reads EVM_PRIVATE_KEY and BNB_RPC_URL from environment variables, which involves access to sensitive credentials and network configuration. Although the script logs general startup information, it does not provide any explicit user-facing warning, comment, or docstring disclosing that it will consume a blockchain private key for trading operations.