T09 · Insecure Skill Coding Practices
Warning
- Location
- SKILL.md:15
- Finding
- Plaintext HTTP Requests Expose Weather Queries to Network Interception## Vulnerability Details **File Location**: `SKILL.md`, lines 15–37 **Vulnerability Type**: Plaintext HTTP communication **Risk Level**: Medium The following documented commands access wttr.in without explicitly requiring HTTPS: ```bash curl -s "wttr.in/London?format=3" ``` ```bash curl -s "wttr.in/London?format=%l:+%c+%t+%h+%w" ``` ```bash curl -s "wttr.in/London?T" ``` ```bash curl -s "wttr.in/Berlin.png" -o /tmp/weather.png ``` ### Technical Analysis URLs without an explicit scheme are interpreted by curl as HTTP URLs. Consequently, the initial weather request is transmitted over plaintext HTTP. A server-side redirect to HTTPS does not protect the initial request because the requested location and HTTP headers have already crossed the network without transport encryption. An attacker able to intercept network traffic could observe requested locations or modify the plaintext response. The attacker could also return a malicious redirect or substitute the downloaded weather image. No evidence indicates that the downloaded image is executed or processed by a privileged component, so arbitrary code execution is not established. ### Attack Path 1. A user or Agent runs one of the documented wttr.in commands. 2. Curl initiates an unencrypted HTTP connection because the URL does not specify `https://`. 3. An attacker positioned on the same untrusted network, or another party capable of intercepting the route, observes or modifies the request. 4. The attacker learns the queried location, alters weather output, injects a redirect, or substitutes the downloaded PNG response. 5. The user or Agent receives attacker-controlled or misleading content. ### Impact Assessment Exploitation requires a network-adjacent or otherwise on-path attacker. It may disclose location queries and compromise the confidentiality and integrity of weather responses. The affected scope is limited to traffic generated by these wttr.i ...[truncated 129 chars]
- Remediation
- ## Remediation Suggestions Replace every wttr.in reference with an explicit HTTPS URL. Configure curl to reject non-HTTPS protocols, report HTTP failures, and follow only secure redirects where redirects are necessary. Recommended examples: ```bash curl --fail --show-error --silent --location \ --proto '=https' --proto-redir '=https' \ "https://wttr.in/London?format=3" ``` ```bash curl --fail --show-error --silent --location \ --proto '=https' --proto-redir '=https' \ "https://wttr.in/Berlin.png" \ --output /tmp/weather.png ``` Apply the same explicit `https://` scheme and protocol restrictions to all other wttr.in examples. If downloaded files are later consumed by another component, validate their media type and content before use.