Cn Password Generator V2

• Outcome: Review
• Latest audit: Sep 16, 2026 · 8:08 AM UTC
• Version: 1.1.2

Overview

This password generator is mostly simple and local, but it can silently produce empty passwords under invalid options, which is concerning for a security tool.

Review before installing if you plan to use this in automation or for real credentials. It is local and dependency-free, but should reject zero or negative lengths, excessive counts, and configurations with no enabled character classes before being relied on for passwords, API keys, or tokens.

A.I.G

Vulnerability Patterns

• Insecure Skill Coding Practices: Finds exploitable flaws such as hardcoded secrets or command injection
• Skill Instruction Hijacking: Alters the agent's session goals or safety constraints when the skill loads
• Agent Memory Poisoning: Writes attacker-controlled rules into memory that affect later sessions
• Remote Payload Retrieval and Execution: Fetches external code whose behavior can change after review
• Embedded Malicious Code: Ships malicious scripts inside the skill and executes them locally

Findings (1)

T09 · Insecure Skill Coding Practices

Warning

• Location: scripts/pwd_gen_v2.py:7

Finding

Unsafe Input Validation Permits Empty Password Generation

Content

View full analysis

Vulnerability Details

File Location: scripts/pwd_gen_v2.py, lines 7-15 and 18-28
Vulnerability Type: Insufficient validation of security-sensitive input
Risk Level: Medium

Vulnerable Code

python

def gen_pwd(length, upper=True, lower=True, digits=True, symbols=True):
    chars = ""
    if upper: chars += string.ascii_uppercase
    if lower: chars += string.ascii_lowercase
    if digits: chars += string.digits
    if symbols: chars += "!@#$%^&*"
    if not chars:
        return ""
    return "".join(secrets.choice(chars) for _ in range(length))

python

parser.add_argument("--length", type=int, default=16)
parser.add_argument("--no-upper", action="store_true")
parser.add_argument("--no-lower", action="store_true")
parser.add_argument("--no-digits", action="store_true")
parser.add_argument("--no-symbols", action="store_true")
parser.add_argument("--count", type=int, default=1)
args = parser.parse_args()

pwds = [gen_pwd(args.length, not args.no_upper, not args.no_lower,
                 not args.no_digits, not args.no_symbols)
         for _ in range(args.count)]

Technical Analysis

The command-line arguments --length and --count have no range validation. In addition, the generator permits all character classes to be disabled simultaneously. Python's range(0) and range() with a negative argument produce no iterations, so a zero or negative password length causes "".join(...) to return an empty string. The explicit if not chars branch also returns an empty string when all character classes are disabled.

These invalid configurations are treated as successful operations: the program prints valid JSON and exits normally instead of rejecting the request. This behavior is unsafe for a utility documented as generating strong passwords, API keys, and tokens. Automated consumers may not distinguish an empty generated value from a legitimate result.

Attack

...[truncated 1171 chars]

Remediation

View remediation

Remediation Suggestions

• Validate --length with an argparse type function and reject zero or negative values. For password use, enforce a documented minimum such as 12 or 16 characters and a reasonable maximum to limit resource consumption.
• Validate --count as a positive, bounded integer to prevent invalid output and excessive CPU, memory, or output consumption.
• Reject configurations in which every character class is disabled. Report a clear error through parser.error(...) and exit with a nonzero status.
• Make gen_pwd() independently validate its arguments so callers that import the function cannot bypass command-line validation.
• Consider guaranteeing at least one character from each enabled class, followed by a cryptographically secure shuffle, if enabled classes are intended as composition requirements rather than merely additions to the candidate pool.
• Add tests covering zero and negative lengths, excessive lengths and counts, zero or negative counts, all character classes disabled, and valid boundary values.

Example validation approach:

python

def positive_bounded_int(value, minimum=1, maximum=1024):
    parsed = int(value)
    if not minimum <= parsed <= maximum:
        raise argparse.ArgumentTypeError(
            f"value must be between {minimum} and {maximum}"
        )
    return parsed

parser.add_argument(
    "--length",
    type=lambda value: positive_bounded_int(value, 12, 1024),
    default=16,
)
parser.add_argument(
    "--count",
    type=lambda value: positive_bounded_int(value, 1, 100),
    default=1,
)

if args.no_upper and args.no_lower and args.no_digits and args.no_symbols:
    parser.error("at least one character class must remain enabled")

SkillSpector

Vulnerability Patterns

• Prompt Injection: Instruction Override, Hidden Instructions, Exfiltration Commands
• Data Exfiltration: External Transmission, Env Variable Harvesting, File System Enumeration
• Privilege Escalation: Excessive Permissions, Sudo/Root Execution, Credential Access
• Supply Chain: Unpinned Dependencies, External Script Fetching, Obfuscated Code
• Excessive Agency: Unrestricted Tool Access, Autonomous Decision Making, Scope Creep

Findings (1)

Natural-Language Policy Violations

Low

• Category: Not specified by scanner
• Confidence: 96% confidence

Finding

The file is primarily written in English, but the footer switches to Chinese promotional language and links without any user opt-in or explanation of a locale-specific requirement. This can violate language/locale policy expectations because it imposes a specific language on some users rather than offering a choice.

Content

No source excerpt is available for this finding.