Back to skill

Security audit

sector-rotation-analyst

Security checks for vulnerabilities and agentic risk

Overview

This skill is a straightforward market-analysis helper that uses a disclosed Finskills API key and does not include executable code or persistence.

Before installing, prefer a pinned installer version or reviewed commit if available. Use a Finskills API key with only the needed permissions, and avoid sending confidential portfolio, strategy, or account information through prompts that may lead to API lookups.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)

T08 · Insecure Dependencies

Warning
Location
README.md:22
Finding

Unpinned Third-Party Installer and Mutable Remote Skill Source

Content
View full analysis

Vulnerability Details

File Location: README.md, lines 22–26
Vulnerability Type: Supply-chain risk caused by unpinned third-party dependencies
Risk Level: Medium

Vulnerable Code:

bash
## Install

```bash
npx skills add https://github.com/finskills/sector-rotation-analyst --skill sector-rotation-analyst
text

### Technical Analysis

The installation command invokes `npx skills` without specifying an audited package version. Depending on the local npm configuration and cache state, `npx` can download and execute the latest available version of the `skills` package. That version may differ from the version reviewed by the project maintainers and may include executable package or lifecycle behavior.

The GitHub repository is also referenced without an immutable commit hash or signed release tag. Consequently, the content installed by the command can change after this audit even though the documented URL remains unchanged.

Trusting both an unpinned npm package and a mutable repository reference creates a supply-chain exposure. A compromised package publisher, npm package, repository account, or repository branch could alter the installer or installed skill after review.

### Attack Path

1. An attacker compromises the npm package publisher, the package distribution channel, the GitHub repository, or an account authorized to modify the repository.
2. The attacker publishes a malicious version of the installer or modifies the repository content referenced by the installation command.
3. A user follows the documented installation procedure and runs the unpinned `npx skills add ...` command.
4. `npx` resolves the attacker-controlled package version, or the installer retrieves the modified repository content.
5. Malicious installer behavior may execute during installation, or altered skill instructions may be installed and subsequently loaded by the agent.

### Impact Assessment

Malicious installer
...[truncated 598 chars]
Remediation
View remediation

Remediation Suggestions

  1. Pin the skills npm package to a specific reviewed version, for example by using an exact version rather than allowing npx to resolve the latest release.
  2. Pin the GitHub source to an immutable, reviewed commit hash or a cryptographically verified signed release.
  3. Record and verify expected integrity information, such as the package-lock entry, npm integrity hash, release checksum, or signed provenance attestation.
  4. Prefer a trusted, locally installed installer whose version is controlled through a lockfile.
  5. Disable package lifecycle scripts during dependency acquisition where supported and where they are not required.
  6. Perform installation in a sandbox or least-privileged environment without production credentials or sensitive environment variables.
  7. Add an update-review process so changes to either the installer version or pinned repository revision require a fresh security review before deployment.
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
Findings (2)

Rp1

Medium
Category
MCP Rug Pull
Confidence
94% confidence
Finding

The install instruction uses npx skills add without pinning a specific version of the tool being executed. npx may fetch and run the latest published package at install time, so a compromised upstream package, typo-squatted dependency, or malicious update could lead to arbitrary code execution on the user's machine. In a README, this is especially relevant because users are encouraged to copy-paste the command directly.

Content

No source excerpt is available for this finding.

Missing User Warnings

Low
Category
Not specified by scanner
Confidence
95% confidence
Finding

The skill clearly instructs use of a third-party API and an API key, but it does not disclose that user prompts and market-related query parameters may be transmitted to an external service. This creates a privacy and transparency issue: users or operators may unknowingly send sensitive portfolio, strategy, or proprietary research context to finskills.net.

Content

No source excerpt is available for this finding.