T09 · Insecure Skill Coding Practices
- Location
SKILL.md:119- Finding
SQL Injection Through Unsanitized Brand Account and Date Placeholders
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This looks like a legitimate ad troubleshooting skill, but it needs review because it handles sensitive internal ad data with broad SQL templates and references privileged impersonation tooling without clear safeguards.
Install only for authorized analysts who are allowed to access the referenced internal ad systems. Before use, require explicit account or campaign identifiers, validate dates and IDs, use read-only scoped database roles, avoid free-form SQL predicates, and do not use impersonation tooling unless a separate approved and audited process requires it.
SKILL.md:119SQL Injection Through Unsanitized Brand Account and Date Placeholders
references/adtrace_funnel.md:152SQL Injection Through Dynamically Constructed Funnel Query Identifiers
references/sql_templates.md:408Arbitrary SQL Predicate Injection Through the id_filter Template
The documentation directs users to an impersonation/login capability ('附身登录') to inspect creative review status. Impersonation tooling is highly sensitive and not necessary for the stated purpose of pulling performance data and generating a root-cause report; if followed, it could enable unauthorized account access, privilege misuse, and access to nonessential user or advertiser data. The skill context makes this especially dangerous because it normalizes privileged access as part of standard troubleshooting guidance.
The trigger phrases are broad, natural-language support requests that overlap with common user asks, which can cause the skill to activate in situations where the user did not intend this specific workflow. Because the skill accesses internal advertiser and bidding datasets, unintended activation can lead to unnecessary retrieval or analysis of sensitive business data. The context increases risk because the skill is powerful and data-intensive, not a harmless helper.
The skill description does not warn users that it accesses potentially sensitive advertiser/account data and internal bidding and analytics datasets. Without transparent notice, users may invoke the skill without understanding the scope of data processing, which undermines informed use and increases the chance of inappropriate sharing or querying of sensitive information. In this context, the omission is material because the skill aggregates multiple internal data sources and may analyze account-level performance details.
The skill documentation explicitly expands the workflow beyond analytics into operational tooling such as change-history, monitoring, creative-review inspection, and other internal platforms. That broadens data access and action surface beyond the stated purpose of case analysis, increasing the chance of unnecessary exposure of sensitive advertiser/account information and misuse of privileged internal systems. In this context, the issue is more dangerous because the skill is framed as an automated troubleshooting assistant, so operators may follow these directions routinely without re-validating need-to-know scope.
The document presents all operational guidance, warnings, and SQL usage instructions only in Chinese. Under the policy, forcing a specific language without user opt-in can be a natural-language policy violation unless the locale restriction is explicitly justified, which is not stated here.
The file title and instructions are entirely in Chinese and the embedded prompt directs the model in Chinese, which effectively fixes the interaction language. Under the policy, language constraints should either offer user choice or be explicitly justified as locale-specific; this file does neither.
This markdown file is written entirely in Chinese and does not indicate that the language choice is optional, configurable, or limited to a specific regional/compliance context. Under the policy, forcing a specific language without user opt-in is a natural-language locale violation.
This markdown file is written as a skill reference and begins with a Chinese-only title, with the entire operational guidance presented exclusively in Chinese. Under the policy rule, forcing a specific language without user opt-in can be a natural-language policy violation when no alternative language or locale choice is offered.