Back to skill

Security audit

Slide Writer

Security checks for vulnerabilities and agentic risk

Overview

The slide generator mostly matches its purpose, but it automatically updates and runs local code, can accidentally embed local files into decks, and includes an unrelated Sonos-control skill.

Review before installing. The slide-generation parts are understandable, but remove or require confirmation for the automatic `git pull`, avoid processing untrusted existing HTML, fix asset path validation and HTML escaping, and remove the bundled Sonos skill unless you intentionally want separate speaker-control capability.

Vulnerability Patterns
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
Findings (4)

T03 · Remote Payload Retrieval and Execution

Error
Location
SKILL.md:39
Finding

Mandatory Unpinned Repository Update Before Local Script Execution

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Error
Location
scripts/inline-images.py:19
Finding

Arbitrary Local File Disclosure Through Unrestricted Image Inlining

Content
View full analysis
``` or an absolute path to another readable file. 3. The mandatory inlining step runs: ```bash python3 scripts/inline-images.py [file].html ``` 4. The script resolves the path without enforcing an asset-root boundary. 5. It re ...[truncated 735 chars]
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Error
Location
scripts/apply-template-branding.py:131
Finding

Persistent HTML and JavaScript Injection Through Unescaped Presentation Metadata

Content
View full analysis
str: return f"{title} — {speaker}" if speaker else title ``` ```python final_title = build_title(args.title, args.speaker) theme_style = load_theme_style(args.theme_id) logo_block, warnings = build_logo_block( primary_id=args.primary_id, primary_alt=args.primary_alt, secondary_id=args.secondary_id, secondary_alt=args.secondary_alt, ) updated = TITLE_RE.sub( f"{final_title}", html_text, count=1 ) ``` ### Technical Analysis The `title` and optional `speaker` command-line values are incorporated into `final_title` without HTML escaping. The value is then inserted directly between `` and `` tags. An attacker-controlled value can terminate the title element and append executable markup. For example, a title containing the following structure can escape the intended context: ```html ``` This is a persistent injection because the payload is written into the generated HTML file. The Skill subsequently mandates opening the output in a browser, providing a direct execution trigger. The script already uses `html.escape` for logo attributes, showing that contextual output encoding is available but was not applied to presentation metadata. ### Attack Path 1. An attacker provides a crafted presentation title or speaker value. 2. The Agent invokes the branding script with that value. 3. `build_title` returns the input without encoding HTML metacharacters. 4. The regular-expression substitution writes the payload into the document head. 5. The workflow executes the mandatory browser-open step. 6. The browser parses the injected markup and executes the attacker's JavaSc ...[truncated 798 chars]
Remediation
View remediation
{escaped_title}", html_text, count=1 ) ``` 2. Use a replacement callback so backslashes in user input are not interpreted specially by the regular-expression replacement engine. 3. Prefer an HTML parser or DOM-aware templating library over regular-expression replacement. 4. Apply contextual escaping to every user-controlled value inserted into HTML, CSS, JavaScript, URLs, or attributes. 5. Add tests containing `<`, `>`, `&`, quotes, closing tags, and backslashes. 6. Add a restrictive Content Security Policy that blocks inline scripts and unauthorized network destinations where compatible with the presentation design. 7. Validate generated output before automatically opening it in a browser. ]]>

T08 · Insecure Dependencies

Warning
Location
skills/sonoscli/SKILL.md:2
Finding

Unrelated Mutable Sonos CLI Dependency Introduces Supply-Chain and LAN-Control Risk

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
Findings (85)

Tp4

High
Category
MCP Tool Poisoning
Confidence
98% confidence
Finding

声明的技能定位是内容生成/排版:把输入材料制作成企业级 HTML 演示文稿。而代码的实际功能是一个后处理工具,仅对现有 HTML 文件中的图片引用进行内联,属于资源打包与依赖消除。两者主目的明显不同:代码既不生成演示文稿,也不改进结构设计,只是修改 img/src 资源引用并覆盖写回文件。此外,代码依赖命令行参数指定 HTML 文件,这种实际触发方式也未反映在声明中。因此这是明显的描述与行为不一致。

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
98% confidence
Finding

声明描述的核心能力是内容生成/转换:把输入材料制作成企业级 HTML 演示文稿。但实际提供的代码只是一个 preview.sh 辅助脚本,用 python3 -m http.server 在本地端口提供静态文件服务,用于预览或访问现有文件。代码中没有任何解析想法、大纲、文档或草稿、生成演示文稿、设计版式或输出 HTML 幻灯片的逻辑。因此其主要行为与声明的主要用途不一致,构成明显不匹配。

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
97% confidence
Finding

声明的用途是“生成/制作企业级 HTML 演示文稿”,但提供的代码并不生成、转换或设计任何演示内容。它只是接收一个现有 HTML 文件路径,并对文件内容做 grep 规则检查与本地资源存在性验证,属于验证/测试工具而非内容生成工具。虽然它与 HTML 演示文稿领域相关,但其主要功能与描述存在实质性偏差,因此应判定为不匹配。

Content

No source excerpt is available for this finding.

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 65)May include surrounding context.

md
读取 [themes/_index.md](themes/_index.md),从用户请求提取公司关键词,优先级从高到低:

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 73)May include surrounding context.

md
读取 [themes/_index.md](themes/_index.md),从用户请求提取公司关键词,优先级从高到低:

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 455)May include surrounding context.

md
读取 [themes/_index.md](themes/_index.md),从用户请求提取公司关键词,优先级从高到低:

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 149)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 181)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 190)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 259)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 260)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 457)May include surrounding context.

md
11. **组件库是起点,不是边界** — `components.md` 提供的是高频可复用参考,不是完整上限;当主题更适合地图、时间带、关系网、年表、分镜、注释图、海报式大字、档案卡、实物标注、时间切片、城市剖面等表达时,应优先为内容发明更合适的新组件。

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 253)May include surrounding context.

md
- 禁止直接编辑 `template.html` 本身

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 280)May include surrounding context.

md
- 禁止直接编辑 `template.html` 本身

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 454)May include surrounding context.

md
- 禁止直接编辑 `template.html` 本身

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 520)May include surrounding context.

md
- 禁止直接编辑 `template.html` 本身

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 261)May include surrounding context.

md
- **`icons.md`**(含图标槽时按需 Grep)— 中文主题 → 英文图标名参考:

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 458)May include surrounding context.

md
- **`icons.md`**(含图标槽时按需 Grep)— 中文主题 → 英文图标名参考:

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 288)May include surrounding context.

md
python3 scripts/apply-template-branding.py [文件名].html \

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 397)May include surrounding context.

md
python3 scripts/inline-images.py [文件名].html

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 440)May include surrounding context.

md
python3 scripts/inline-images.py [文件名].html

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 405)May include surrounding context.

md
./scripts/smoke-test.sh [文件名].html

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 441)May include surrounding context.

md
./scripts/smoke-test.sh [文件名].html

Ae1

High
Category
analysis-evasion
Confidence
100% confidence
Finding

Referenced artifact was not completely inspected

Content

Scanner excerpt · SKILL.md (reported line 460)May include surrounding context.

md
| [examples/index.html](examples/index.html) | 完整示例文档 | 需要查阅组件骨架时 |

Hidden Instructions

High
Category
Prompt Injection
Confidence
70% confidence
Finding

Hidden instructions were detected in comments or invisible text. These could contain malicious directives. Manual review is recommended.

Content

Scanner excerpt · components.md (reported line 11)May include surrounding context.

两列 / 三列 Grid

html
<!-- 两列等宽 -->
<div class="two-col">
    <!-- 左列内容 -->
    <!-- 右列内容 -->