T09 · Insecure Skill Coding Practices
- Location
SKILL.md:36- Finding
Unsafe interpolation of user-controlled search queries into a shell command
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This shopping skill is coherent, but it needs Review because its shell examples can mishandle user search text and it under-discloses privacy considerations for sensitive searches and optional email use.
Review before installing. Use this only if you are comfortable sending product searches, including possibly health, family, or preference details, to AirShelf. Agents should URL-encode parameters or use a structured HTTP client instead of raw string substitution in shell commands, and should ask before checkout or before sending an optional email address.
SKILL.md:36Unsafe interpolation of user-controlled search queries into a shell command
Remote code is downloaded and executed. This bypasses code review and could introduce malicious code.
Find products by natural language query. Returns structured data with Decision Packs.
curl -s "https://dashboard.airshelf.ai/api/search?q=QUERY&limit=5" | python3 -m json.tool
Parameters:
The activation guidance is broad enough to trigger on generic shopping, recommendation, or problem-description requests, which can cause the agent to send user queries to an external commerce service without sufficiently narrow user intent. In this context, problem-based examples such as health- or baby-related needs increase the risk of transmitting sensitive preference or health-adjacent information to a third party unnecessarily.
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
Example:
curl -s "https://dashboard.airshelf.ai/api/search?q=natural+mosquito+repellent+for+babies&limit=3"
The skill invites collection of an optional customer email for checkout tracking but does not instruct the agent to warn the user that this personal data will be transmitted to a third-party merchant workflow. That creates a privacy and consent gap, especially because checkout involves external services and the email is not strictly required for core functionality.
No suspicious patterns detected.