T09 · Insecure Skill Coding Practices
- Location
SKILL.md:32- Finding
Shell Command Injection Through an Unvalidated User-Supplied City Name
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is a coherent date and weather helper, but its weather instructions include unsafe shell-based lookups for user-supplied city names that should be reviewed before use.
Install only if you are comfortable with live weather queries being sent to third-party services. The skill should be revised to use a structured HTTPS request method, URL-encode or validate city names, avoid shell interpolation of user input, and explicitly use https:// for wttr.in before routine use.
SKILL.md:32Shell Command Injection Through an Unvalidated User-Supplied City Name
SKILL.md:32Weather Requests Use an Implicit Plaintext HTTP Scheme
The skill’s trigger scope is very broad, covering common requests about date and weather that occur frequently in normal conversation. This can cause over-triggering, unnecessary external lookups, and unintended routing to this skill when the user did not explicitly ask for it, increasing privacy and reliability risk.
The skill hardcodes Chinese-language weather output via lang=zh without checking the user’s language preference. This can produce mismatched output, degrade usability, and in multilingual contexts may cause the agent to ignore user expectations or platform language settings.
The skill instructs the agent to send data to an external weather API, which constitutes outbound transmission to a third party. Even if the transmitted data is limited to coordinates or city names, it can disclose user location preferences or inferred location context to an external service without any privacy notice or minimization guidance.
Open-Meteo(程序化获取): 需要先获取城市坐标,然后查询:
curl -s "https://api.open-meteo.com/v1/forecast?latitude=30.6&longitude=114.3¤t_weather=true&hourly=relativehumidity_2m,apparent_temperature,uv_index&timezone=Asia/Shanghai"