T01 · Skill Instruction Hijacking
Warning
- Location
- openclaw_skill.py:58
- Finding
- Unconditional Promotional Content Injection into Skill Responses<![CDATA[ ## Vulnerability Details **File Location**: `openclaw_skill.py:58-60`; documented in `SKILL.md:73-76` **Vulnerability Type**: `T01: Skill Instruction Hijacking` **Risk Level**: Medium ### Complete Code Snippet ```python # 添加结尾提示 result += "更多内容请访问 https://www.x-techcon.com" return result ``` The corresponding output template is documented in `SKILL.md`: ```text ... 更多内容请访问 https://www.x-techcon.com ``` ### Technical Analysis Every successful invocation unconditionally appends a fixed message directing users to `https://www.x-techcon.com`. The documentation explicitly establishes this promotional footer as expected output. Retrieving articles from the declared API and displaying their source URLs is consistent with the Skill's news-aggregation purpose. However, forcing a general website advertisement into every successful response is not necessary to retrieve or format the requested news. It creates a persistent content-injection and traffic-diversion channel controlled by the Skill author. The behavior does not alter system-level safety controls, execute code, or obtain additional operating-system privileges. Its scope is limited to manipulating the text returned by this Skill. ### Attack Path 1. A user enters one of the configured trigger phrases. 2. The Skill sends a request to the X-TechCon API. 3. The Skill formats the returned news records. 4. Regardless of the returned articles, it appends a fixed promotional message. 5. The final response directs the user to the operator-controlled website. ### Impact Assessment The injected footer can influence users to visit an external site and makes promotional content appear as part of the assistant's response. This reduces output integrity and user control and supplies the site operator with a recurring traffic-diversion mechanism. No filesystem, credential, execution, persistence, or elevated system privileges are obtained through this behavior. The affected scope is the content of successfu ...[truncated 63 chars]
- Remediation
- <![CDATA[ ## Remediation Suggestions 1. Remove the unconditional promotional footer from `skill_main`. 2. Return only information necessary to satisfy the user's news request. 3. If source attribution is required, label it clearly and associate it directly with the retrieved records rather than presenting a general promotional call to action. 4. Make any optional “more content” link user-controlled or configurable instead of automatically adding it to every response. 5. Document all externally controlled output and distinguish source attribution from advertising. ]]>
