T09 · Insecure Skill Coding Practices
Warning
- Location
- references/weekly-review-guide.md:61
- Finding
- Hard-Coded Feishu Recipient May Cause Unauthorized Disclosure of Private Activity<![CDATA[ ## Vulnerability Details **File Location**: `references/weekly-review-guide.md`, lines 61-66 **Vulnerability Type**: Hard-coded external message recipient **Risk Level**: Medium ### Vulnerable Documentation Snippet The following is an English translation of the complete affected source segment: ```markdown ### 5. Send Summary Send via Feishu to the hard-coded recipient, including: - Weekly learning highlights (2-3 sentences) - Number of knowledge-map changes - Key focus for next week ``` The recipient named in the original source is fixed rather than dynamically resolved from the current user. ### Technical Analysis The weekly-review workflow collects information from daily memory logs, code changes, pull requests, research activity, documents, and technical problems. It then instructs the agent to transmit a summary through Feishu to a specifically named recipient. This conflicts with `SKILL.md:113-114`, which describes the intended recipient as the current user. The guide does not require the agent to: - Verify that the hard-coded recipient is the requesting user. - Obtain consent immediately before transmission. - Preview the information that will be disclosed. - Redact confidential project, pull-request, or research details. - Skip external transmission when the recipient cannot be verified. The repository does not include code that directly performs the Feishu transmission, so exploitation depends on an agent environment that provides a messaging tool and follows documentation as executable instructions. Nevertheless, in such an environment the fixed-recipient instruction creates a concrete unintended-disclosure path and exceeds the minimum privileges needed to generate a local weekly review. ### Attack Path 1. A user or scheduled workflow invokes weekly-review mode. 2. The Skill reads up to seven days of memory logs and examines recent notes, pull requests, code changes, research, and technical problems. 3. The Skill generates a wee ...[truncated 1098 chars]
- Remediation
- <![CDATA[ ## Remediation Suggestions 1. Remove the hard-coded recipient from `references/weekly-review-guide.md`. 2. Default weekly-review mode to generating and storing the report locally without external transmission. 3. Require the user to explicitly select or confirm the Feishu recipient immediately before every send operation. 4. Display a complete preview of the outgoing message and require confirmation before invoking the messaging tool. 5. Verify that the selected recipient corresponds to the requesting user or an explicitly authorized destination. 6. Redact secrets, private repository names, unpublished pull-request details, personal data, and confidential technical information. 7. Treat `--quick` as permission to skip workflow confirmations only; it must not bypass confirmation for external data transmission. 8. Add an explicit configuration option such as `send_weekly_summary: false`, disabled by default. 9. Record the destination and user authorization decision in a local audit log without storing sensitive message contents. 10. Update the instruction to state that sending must be skipped if recipient identity, authorization, or messaging scope cannot be verified. ]]>
