T09 · Insecure Skill Coding Practices
- Location
agent.py:76- Finding
Unbounded Image Quantity Enables Resource Exhaustion
- Content
View full analysis
Dict: """调用即梦生成""" timestamp = datetime.now().strftime("%Y%m%d_%H%M%S") output_dir = f"output/jimeng/{timestamp}" # TODO: 实际调用即梦脚本 images = [] for i in range(quantity): images.append({ "path": f"{output_dir}/image_{i+1}.png", "thumbnail": f"{output_dir}/thumb_{i+1}.png" }) ``` ```python def _call_liblib(self, prompt: str, negative_prompt: str, quantity: int, brief: Dict) -> Dict: """调用 Liblib 生成""" timestamp = datetime.now().strftime("%Y%m%d_%H%M%S") output_dir = f"output/liblib/{timestamp}" product_type = brief.get("product_info", {}).get("type", "") model = self._recommend_liblib_model(product_type) # TODO: 实际调用 Liblib 脚本 images = [] for i in range(quantity): images.append({ "path": f"{output_dir}/image_{i+1}.png", "thumbnail": f"{output_dir}/thumb_{i+1}.png" }) ``` Equivalent unbounded loops are exposed by the public `generate()` methods in both tool wrappers: ```python images = [] for i in range(quantity): images.append({ "path": os.path.join(output_path, f"image_{i+1}.png"), "thumbnail": os.path.join(output_path, f"thumb_{i+1}.png") }) ``` ### Technical Analysis The externally supplied `creative_brief.quantity` value is passed directly to `range()` without validation. Although `skill.json` declares `max_quant ...[truncated 1661 chars]- Remediation
View remediation
int: if isinstance(value, bool) or not isinstance(value, int): raise ValueError("quantity must be an integer") if not 1 <= value <= MAX_QUANTITY: raise ValueError(f"quantity must be between 1 and {MAX_QUANTITY}") return value ``` Invoke this validation from `MakerAgent.generate()`, `JimengTool.generate()`, `LiblibTool.generate()`, and regeneration entry points before allocating results or creating directories. ]]>
