T09 · Insecure Skill Coding Practices
- Location
scripts/dahua_iot_client.py:372- Finding
Default request logging exposes reversible device passwords and plaintext Wi-Fi credentials
- Content
View full analysis
Dict[str, Any]: try: headers = self._build_headers() url = self.config['api_base_url'] + endpoint self._log(f"[API] POST {endpoint}") self._log(f"[DATA] {json.dumps(data, ensure_ascii=False)}") response = self.session.post(url, headers=headers, json=data, timeout=timeout) result = response.json() resp_preview = json.dumps(result, ensure_ascii=False) self._log(f"[RESP] {resp_preview[:200]}{'...' if len(resp_preview) > 200 else ''}") return result ``` ```python def control_device_wifi( self, device_id: str, ssid: str, bssid: Optional[str] = None, password: Optional[str] = None, link_enable: Optional[bool] = None, channel_sn: Optional[str] = None ) -> Dict[str, Any]: self._log(f"\n[WiFi] Controlling device wifi: {device_id}") data = {'deviceId': device_id, 'ssid': ssid} if bssid: data['bssid'] = bssid if password: data['password'] = password if link_enable is not None: data['linkEnable'] = link_enable if channel_sn: data['channelSn'] = channel_sn return self._request(API_CONTROL_DEVICE_WIFI, data) ``` ```python def modify_dev_code( self, device_id: str, ...[truncated 3412 chars]- Remediation
View remediation
