T09 · Insecure Skill Coding Practices
Warning
- Location
scripts/get_status.sh:5- Finding
Plaintext Credential Storage and Process Argument Exposure
- Content
View full analysis
- Remediation
View remediation
Security audit
Devin_dingcheng
Security checks for vulnerabilities and agentic risk
Overview
This skill is a small, read-only device-status helper, but users should treat the API key and phone number as sensitive.
Before installing, confirm that cd6969.com is the correct API for your device account. Do not commit or share a filled-in script containing your API key, phone number, or IMEI; prefer environment variables or a private local config file with restricted permissions. Rotate any real credentials that were pasted into shared files or logs.
Vulnerability Patterns
- Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
- Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
- Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
- Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
- Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)
Vulnerability Patterns
- Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
- MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
- Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
- Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
- Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
Findings (9)
Undeclared Tool Scope
Medium
- Category
- MCP Least Privilege
- Confidence
- 90% confidence
- Finding
The skill documents shell-based usage (
curland a local script) but does not declare any tool scope or execution permissions. This creates an authorization and review gap: an agent or user may invoke shell/network behavior that is not explicitly constrained, increasing the chance of unintended command execution or data exfiltration.- Content
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 94% confidence
- Finding
The documentation instructs users to POST a key and phone number to an external service without any warning about handling secrets, PII, logging exposure, retention, or third-party trust. Even though HTTPS is used, this can still leak credentials through shell history, terminal logs, copied examples, or misuse by downstream agents.
- Content
External Transmission
Medium
- Category
- Data Exfiltration
- Confidence
- 92% confidence
- Finding
The skill instructs sending sensitive identifiers (
key,tel) to an external domain, which is an external transmission of secrets and personal data. In this context the transmission appears functionally necessary to query device state, but it is still dangerous because it expands the trust boundary to a third-party service and may expose credentials or device metadata if mishandled.- Content
快速查询
bash curl -s -X POST "https://www.cd6969.com/admin.php?s=/Admin/ApiV2/getList.html" \ -H "Content-Type: application/json" \ -d '{"key":"你的KEY","tel":"你的手机号"}'
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 91% confidence
- Finding
The script directly uses credential-like values (KEY, TEL, IMEI) embedded in the script template, which encourages insecure secret handling and raises the risk of accidental disclosure through source control, backups, or local file exposure. In this IoT context, those values can enable unauthorized querying of device status or account-associated data if leaked.
- Content
External Transmission
Medium
- Category
- Data Exfiltration
- Confidence
- 93% confidence
- Finding
The script performs an external network transmission to a vendor-controlled API endpoint and includes sensitive values in the request body. In the context of an agent skill, outbound transmission of credentials and personal identifiers is security-relevant because users may not expect data exfiltration, and compromise or misuse of the remote service could expose account or device information.
- Content
sh IMEI="你的IMEI" URL="https://www.cd6969.com/admin.php?s=/Admin/ApiV2/getList.html" response=$(curl -s -X POST "$URL" \ -H "Content-Type: application/json" \ -d "{\"key\":\"$KEY\",\"tel\":\"$TEL\"}")
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 95% confidence
- Finding
The script sends a phone number and API key to a third-party remote endpoint, which is a genuine data exposure/privacy concern because these are sensitive identifiers and credentials. Although this transmission appears necessary for the advertised device-query functionality, the file provides no user-facing disclosure, no consent flow, and no guidance on handling or minimizing the data being sent.
- Content
Natural-Language Policy Violations
Low
- Category
- Not specified by scanner
- Confidence
- 87% confidence
- Finding
The file presents all user-facing instructions in a single language without offering an opt-in or documenting that the skill is intended only for a Chinese-speaking or region-specific audience. Under the stated policy, forcing a specific language without user choice can be a natural-language policy violation.
- Content
Natural-Language Policy Violations
Low
- Category
- Not specified by scanner
- Confidence
- 86% confidence
- Finding
The human-readable description and error text are presented solely in Chinese, with no opt-in language selection or note that the skill is intentionally region-specific. Under the policy, forcing a specific language without user choice can be a natural-language policy violation.
- Content
Natural-Language Policy Violations
Low
- Category
- Not specified by scanner
- Confidence
- 84% confidence
- Finding
The script emits a Chinese-only error message to the user, which enforces a single language experience. There is no indication that the skill is restricted to a Chinese locale or that users can opt into another language.
- Content
Static analysis
No suspicious patterns detected.