T09 · Insecure Skill Coding Practices
Warning
- Location
scripts/PansModel-Manager.py:216- Finding
API Credentials Exposed Through Command-Line Arguments and Unprotected Plaintext Storage
- Content
View full analysis
- Remediation
View remediation
Security audit
PansModel Manager
Security checks for vulnerabilities and agentic risk
Overview
This model-management skill appears purpose-aligned, but it handles API keys in a way users should review carefully before installing.
Review this before installing if you will use real provider keys. Prefer disposable or restricted API keys, rotate any key entered on the command line, check permissions on ~/.openclaw-pansclaw/openclaw.json, and back up the config before using delete or switch commands.
Vulnerability Patterns
- Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
- Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
- Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
- Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
- Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)
Vulnerability Patterns
- Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
- MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
- Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
- Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
- Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
Findings (7)
Undeclared Tool Scope
Medium
- Category
- MCP Least Privilege
- Confidence
- 88% confidence
- Finding
The skill clearly describes functionality that reads and writes a persistent configuration file, but it does not declare any explicit tool scope or permissions boundaries. That omission increases the risk of over-broad file access and makes it harder for users or the host platform to constrain what the skill may modify.
- Content
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 95% confidence
- Finding
The documentation instructs users to enter API keys and modify model settings without warning that credentials will be stored persistently in a local config file. This can lead to accidental secret exposure, unsafe file permissions, or users making destructive configuration changes without understanding the persistence and side effects.
- Content
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 92% confidence
- Finding
The delete command removes a provider from the persisted configuration and saves the change immediately. Although there is a warning when deleting the current default provider, there is no explicit confirmation step before this irreversible config change.
- Content
Missing User Warnings
Medium
- Category
- Not specified by scanner
- Confidence
- 97% confidence
- Finding
The script takes the API key as a positional command-line argument and persists it directly into the JSON config file. Command-line arguments can be exposed through shell history, process listings, logs, and screenshots, which can leak long-lived credentials to other local users or monitoring systems.
- Content
External Transmission
Medium
- Category
- Data Exfiltration
- Confidence
- 60% confidence
- Finding
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
- Content
md 示例: # 添加 DeepSeek 模型 python3 model-manager.py add deepseek https://api.deepseek.com/v1 sk-xxx deepseek-chat # 切换到指定模型 python3 model-manager.py switch deepseek/deepseek-chat
External Transmission
Medium
- Category
- Data Exfiltration
- Confidence
- 60% confidence
- Finding
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
- Content
python 示例: # 添加 DeepSeek 模型 python3 model-manager.py add deepseek https://api.deepseek.com/v1 sk-xxx deepseek-chat # 切换到指定模型 python3 model-manager.py switch deepseek/deepseek-chat
Natural-Language Policy Violations
Low
- Category
- Not specified by scanner
- Confidence
- 88% confidence
- Finding
User-facing natural-language strings, help text, and documentation in this file are exclusively in Chinese. Under the stated policy, forcing a specific language without opt-in or justification is a locale-policy concern.
- Content
Static analysis
No suspicious patterns detected.