Back to skill

Security audit

Pans Daily Sales Brief

Security checks for vulnerabilities and agentic risk

Overview

The skill mostly matches its sales-brief purpose, but it can modify business pipeline data and runs unverified helper scripts outside the reviewed package.

Review before installing if this would hold real customer, contract, or revenue data. Use it only with non-sensitive or backed-up pipeline data, and be aware that write and search operations depend on other local scripts outside this reviewed package. The evidence supports Review rather than a malicious classification because the risky behavior is largely tied to the stated sales workflow and no intentional exfiltration, deception, or destructive payload was found.

Vulnerability Patterns
  • Tool Hijacking and SpoofingModifies or replaces tools so legitimate-looking calls execute attacker logic
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (2)

T07 · Tool Hijacking and Spoofing

Warning
Location
scripts/brief.py:62
Finding

Execution of Unverified External Helper Scripts

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Warning
Location
scripts/brief.py:38
Finding

Pipeline Corruption Can Cause Silent Replacement with Sample Data

Content
View full analysis
Dict[str, Any]: """加载 pipeline 数据,如果不存在则返回初始化数据。""" if not PIPELINE_FILE.exists(): return get_initial_data() try: with open(PIPELINE_FILE, "r", encoding="utf-8") as f: return json.load(f) except (json.JSONDecodeError, IOError) as e: print(f"警告: 读取数据文件失败: {e}", file=sys.stderr) return get_initial_data() ``` Mutation branches later save the returned object without distinguishing successfully loaded production data from fallback sample data: ```python if args.add_client: try: client_data = json.loads(args.add_client) client = add_client(data, client_data) save_pipeline(data) ``` Equivalent save behavior is used by the add-contract, add-lead, and update branches. ### Technical Analysis The loader treats two materially different states as equivalent: - The pipeline file does not exist and requires initialization. - The pipeline file exists but is malformed, unreadable, partially written, or temporarily inaccessible. In the second case, the function returns `get_initial_data()`, which contains sample customer, contract, lead, and financial records. The caller receives no machine-readable indication that loading failed. If the requested operation mutates data, `save_pipeline(data)` may write the sample-backed object over the existing pipeline. Consequently, a recoverable read or parsing failure can be converted into destructive replacement of production records. The risk is amplified because the external write helper's failure is only printed to standard error, while callers can still print a success message. ### Attack Path 1. The existing `pipeline.json` becomes invalid or unreadable. This may ...[truncated 1066 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Behavioral ASTexec() Call, eval() Call, Dynamic Import
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
Findings (12)

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
89% confidence
Finding

The skill documents execution of a local Python script and use of shell/file capabilities, but it does not declare any explicit tool scope such as allowed-tools or permissions. This creates an authorization ambiguity where an agent may invoke broader local capabilities than users expect, increasing the risk of unintended file access or command execution.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The trigger phrases include very common terms like '销售简报', '每日报告', 'pipeline', 'daily brief', and 'sales report', which are likely to match ordinary user conversations unrelated to this specific skill. Overbroad activation can cause the skill to run unexpectedly, exposing or modifying locally stored customer, contract, and pipeline data without clear user intent.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The skill description explains how to add clients, contracts, and leads to a local JSON database, but it does not clearly warn users that potentially sensitive customer and contract information will be stored on disk under the user's home directory. In a sales context, this data may include confidential commercial information, so silent local persistence increases privacy, compliance, and accidental disclosure risks.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
90% confidence
Finding

The file's natural-language interface, usage text, and generated output are entirely in Chinese, which effectively imposes a language choice on users. There is no indication that the skill supports language selection or that the Chinese-only constraint is explicitly documented as a justified regional requirement.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The script persists customer, contract, lead, and revenue data to disk under the user's home directory without any prominent notice, consent flow, retention policy, or protection controls. Because this is commercially sensitive data, undisclosed local persistence can cause confidentiality loss through local compromise, backups, shared accounts, or later access by other tools.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
87% confidence
Finding

The skill exceeds its apparent scope by invoking external helper scripts, including one for file writes and another for search, which expands execution capability and trust to code outside this file. In a skill handling customer and contract data, hidden delegation to other scripts increases the attack surface and can lead to unexpected code execution or data exposure if those helpers are modified or untrusted.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
87% confidence
Finding

The skill performs file writes by executing a separate script without clearly informing the user that another executable component will run. This hidden helper execution is dangerous because it broadens the trust boundary: if the helper is altered, replaced, or behaves unexpectedly, sensitive sales data could be modified, copied, or written elsewhere.

Content

No source excerpt is available for this finding.

subprocess module call

Medium
Category
Dangerous Code Execution
Confidence
70% confidence
Finding

subprocess module calls execute external commands. Without careful input validation, this enables command injection.

Content

Scanner excerpt · scripts/brief.py (reported line 76)May include surrounding context.

python
try:
        write_script = Path.home() / "Library/Application Support/QClaw/openclaw/config/skills/qclaw-text-file/scripts/write_file.py"
        result = subprocess.run(
            ["/opt/homebrew/bin/python3.11", str(write_script),
             "--path", str(PIPELINE_FILE),
             "--content-file", tmp_path],

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The competitor-news feature can trigger external searches via another script, but the user is not clearly warned that network requests may be made or what query terms will be sent. In a sales workflow, even outbound searches can leak strategic interest patterns or internal competitor lists to external services, creating privacy and business-intelligence exposure.

Content

No source excerpt is available for this finding.

subprocess module call

Medium
Category
Dangerous Code Execution
Confidence
70% confidence
Finding

subprocess module calls execute external commands. Without careful input validation, this enables command injection.

Content

Scanner excerpt · scripts/brief.py (reported line 339)May include surrounding context.

python
for competitor in competitors[:3]:  # 只搜索前3个竞品,避免耗时过长
                query = f"{competitor} GPU cloud AI算力 新闻"
                try:
                    result = subprocess.run(
                        ["/opt/homebrew/bin/python3.11", str(pansxng_script), query, "--days", str(days)],
                        capture_output=True,
                        text=True,

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
80% confidence
Finding

This JSON file stores user-facing text fields such as company names, stages, notes, sources, and priorities entirely in Chinese, with no indication that the skill is region-specific or that users can opt into this locale. Under the stated policy, forcing a specific language without documented opt-in or justification can be a natural-language policy violation.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Low
Category
Not specified by scanner
Confidence
92% confidence
Finding

The manifest emphasizes automatic summarization of follow-up customers, expiring contracts, leads, and competitor dynamics, plus maintaining pipeline data at a high level. The code exposes broad record-management operations including add, update, and full listing of clients, contracts, and leads, making it a more general pipeline database utility than just a brief generator.

Content

No source excerpt is available for this finding.