T08 · Insecure Dependencies
Warning
- Location
- setup.sh:75
- Finding
- Unpinned Python dependencies allow uncontrolled supply-chain changes## Vulnerability Details **File Location**: `setup.sh:75-83` **Vulnerability Type**: Unpinned third-party dependencies **Risk Level**: Medium ### Vulnerable Code ```bash pip install --upgrade pip pip install basic-pitch librosa soundfile mido # Install optional music21 for advanced key detection echo "" echo "Install music21 for enhanced key detection? [Y/n]" read -r response if [[ ! "$response" =~ ^([nN][oO]|[nN])$ ]]; then pip install music21 ``` The manual installation instructions repeat this unsafe dependency-installation pattern in `SKILL.md:95`: ```bash pip install basic-pitch librosa soundfile mido music21 ``` ### Technical Analysis The installer retrieves the latest versions of multiple packages without pinning exact versions or verifying cryptographic hashes. It also upgrades `pip` to an unspecified version. Consequently, the effective code installed and executed can change over time without any corresponding change to this reviewed project. Python packages may execute package-controlled build or installation logic during installation. A compromised package release, compromised package index, dependency-confusion condition, or malicious transitive dependency could therefore execute code under the account running `setup.sh`. Lack of a lock file also prevents reproducible dependency resolution and makes it difficult to establish which code was audited. ### Attack Path 1. An attacker compromises a listed package, one of its transitive dependencies, or the relevant package-distribution channel. 2. The attacker publishes a malicious release that remains compatible with the unconstrained package requirement. 3. A user runs `setup.sh` or follows the manual installation command in `SKILL.md`. 4. `pip` resolves and downloads the attacker-controlled release because no version or hash restrictions apply. 5. Malicious installation or runtime code executes with the permissions of the installing use ...[truncated 575 chars]
- Remediation
- ## Remediation Suggestions 1. Create a reviewed dependency lock file containing exact versions for all direct and transitive dependencies. 2. Record cryptographic hashes for every distribution and install with `pip --require-hashes`. 3. Replace the unconstrained commands with a command such as: ```bash python -m pip install --require-hashes -r requirements.lock ``` 4. Pin the installer tooling instead of implicitly upgrading `pip` to the latest release. 5. Generate lock files in a controlled environment and review dependency changes before updating them. 6. Use a trusted package index explicitly and apply controls against dependency confusion where private dependencies are introduced. 7. Update `SKILL.md` so its manual installation instructions use the same locked and hash-verified dependency set. 8. Consider installing with network restrictions and minimum required user privileges.