T09 · Insecure Skill Coding Practices
- Location
SKILL.md:72- Finding
Recursive In-Place Scrubbing Can Corrupt Files Without Recovery
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is meant to remove sensitive data before publishing, but its scrubber can recursively overwrite many files in place and falsely claims backups are made.
Review this skill before installing or using it. Do not run Invoke-PrivacyScrub on a real project unless you have your own backup and have narrowed the target path, because the artifact's backup claim is not implemented and the scrubber may alter unintended files while still missing some sensitive data categories.
SKILL.md:72Recursive In-Place Scrubbing Can Corrupt Files Without Recovery
SKILL.md:27Privacy Scrubber Does Not Remove Several Sensitive Data Classes It Claims to Address
The scrub function recursively enumerates files and overwrites them in place, but the markdown does not clearly warn users about the scope and destructive nature of those modifications. In a pre-publish workflow, this can lead to unintended bulk edits across a directory tree, potentially altering non-target files or damaging content without review.
The documentation claims original files are backed up before scrubbing, but the implementation overwrites files in place with Out-File and contains no backup logic. This creates a real integrity and recovery risk: users may permanently lose original content, including incorrectly redacted or corrupted files, because the behavior is safer on paper than in reality.
The trigger section says to use the skill 'Before any skill publish,' 'Before git push of skills,' and 'After copying skill from working directory' without defining exclusions, exact scope, or negative examples. These conditions are broad enough to cause unintended invocation in routine workflows, especially 'after copying skill from working directory,' which is ambiguous.
No suspicious patterns detected.