T09 · Insecure Skill Coding Practices
Error
- Location
- scripts/minimax_music.py:21
- Finding
- API credential and user-content disclosure through an unrestricted endpoint<![CDATA[ ## Vulnerability Details **File Location**: `scripts/minimax_music.py:21-26, 42-72`; equivalent behavior in `scripts/minimax_tts.py:21-26, 44-74`, `scripts/minimax_image.py:20-36, 60-65`, and `scripts/minimax_video.py:21-34, 62-67` **Vulnerability Type**: Arbitrary credential-bearing API destination **Risk Level**: High ### Vulnerable Code ```python API_KEY = os.getenv("MINIMAX_API_KEY") # China Mainland: https://api.minimaxi.com/v1 # Overseas: https://api.minimax.io/v1 API_BASE = os.getenv("MINIMAX_API_BASE") if not API_BASE: raise SystemExit("ERROR: MINIMAX_API_BASE is not set.") ``` ```python if not API_KEY: raise SystemExit("ERROR: MINIMAX_API_KEY is not set.\n export MINIMAX_API_KEY='your-key'") payload = { "model": model, "audio_setting": { "sample_rate": sample_rate, "bitrate": bitrate, "format": fmt, }, "output_format": output_format, } if prompt: payload["prompt"] = prompt if lyrics: payload["lyrics"] = lyrics if is_instrumental: payload["is_instrumental"] = True if lyrics_optimizer: payload["lyrics_optimizer"] = True resp = requests.post( f"{API_BASE}/music_generation", headers={ "Authorization": f"Bearer {API_KEY}", "Content-Type": "application/json", }, json=payload, timeout=timeout, ) ``` ### Technical Analysis All four MiniMax clients obtain the credential from `MINIMAX_API_KEY` and the request destination from the independent, environment-controlled `MINIMAX_API_BASE` variable. They do not verify that the URL uses HTTPS, that its hostname is an official MiniMax endpoint, or that it contains no embedded credentials or unsafe redirect behavior. As a result, a process-environment change can redirect the Bearer credential to an arbitrary server. The same request also contains user-provided prompts, lyrics, TTS text, or video/image descriptions. Transmitting those values to the legitimate service is required for media generation ...[truncated 1622 chars]
- Remediation
- <![CDATA[ ## Remediation Suggestions 1. Replace the mandatory arbitrary base URL with a trusted default: ```python API_BASE = "https://api.minimax.io/v1" ``` 2. If regional endpoint selection is required, map a constrained region value to an exact allowlist: ```python ALLOWED_BASES = { "overseas": "https://api.minimax.io/v1", "china": "https://api.minimaxi.com/v1", } ``` 3. Parse the URL and require: - `https` as the scheme; - an exact approved hostname; - no username or password component; - the expected port and path prefix. 4. Disable automatic redirects for credential-bearing requests or validate every redirect before following it. Never forward the `Authorization` header to a different host. 5. Apply the same validation helper consistently to image, video, music, and TTS clients. 6. Document endpoint selection and explicitly warn that API keys must only be sent to official MiniMax domains. 7. Prefer narrowly scoped, revocable API keys and rotate any credential used with the current implementation. ]]>