T09 · Insecure Skill Coding Practices
- Location
SKILL.md:23- Finding
User-Controlled File Paths May Enable Shell Command or Argument Injection
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill does what it says: compares user-chosen files and reports differences, with minor cautions about output language and safe path handling.
Before installing, expect this skill to inspect the two files or directories you ask it to compare and to produce its report in Chinese. Use it only with files you intend the agent to read, and prefer agents or workflows that pass file paths safely rather than concatenating raw paths into shell commands.
SKILL.md:23User-Controlled File Paths May Enable Shell Command or Argument Injection
The manifest description says to use the skill when the user asks to compare files, find differences between documents, generate a diff report, or check what changed between two versions. These are broad natural-language triggers and the file does not provide exclusion conditions or tighter constraints, which could cause the skill to match ordinary comparison requests more broadly than intended.
The skill says it will generate a structured difference report in Chinese, and later reiterates that the report should be presented in Chinese. This imposes a language constraint without user opt-in, which is a natural-language policy violation under the locale-choice rule.
The instruction to present the report in Chinese with clear sections is a hard-coded locale requirement. Because the file does not provide an opt-in mechanism or a documented justification for restricting output to Chinese, it conflicts with the language/locale policy.
The note says to explain what changed in plain Chinese after showing diff output. This repeats the same mandatory language requirement without any user choice or documented regional justification.
No suspicious patterns detected.