Back to skill

Security audit

酒店竞对调研openclaw助手

Security checks for vulnerabilities and agentic risk

Overview

The skill appears to be a basic hotel report generator, but its advertised automatic hotel-search capability is not implemented and it has avoidable input-handling and dependency risks.

Review this before installing if you need real automatic competitor discovery: the packaged script does not implement that feature. If used anyway, run it only on trusted Excel files or manually entered data, review generated Markdown before sharing, and consider pinning/removing dependencies before installation.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (2)

T09 · Insecure Skill Coding Practices

Warning
Location
scripts/hotel_analysis.py:73
Finding

Unescaped User-Controlled Data Injected into Generated Markdown Reports

Content
View full analysis
Remediation
View remediation

T08 · Insecure Dependencies

Note
Location
requirements.txt:1
Finding

Unpinned and Unnecessary Third-Party Dependencies Increase Supply-Chain Exposure

Content
View full analysis
=2.28.0 pandas>=1.5.0 openpyxl>=3.0.0 pyyaml>=6.0 argparse>=1.4.0 ``` ### Technical Analysis All declared packages use open-ended minimum-version constraints. Consequently, two installations performed at different times can resolve to materially different package versions without any review or source change in this project. The file also contains no integrity hashes. The implementation only imports `pandas` for optional Excel processing and otherwise relies on Python standard-library modules. `requests` and `pyyaml` are not used by the reviewed script. Python 3 already supplies the `argparse` module in its standard library, making installation of a separate `argparse` distribution unnecessary for this program. Installing unused packages expands the number of package archives and installation processes that must be trusted. Open-ended constraints also allow a future compromised or maliciously modified release satisfying the minimum version to be selected automatically. No evidence was found that the currently named packages are malicious. The finding concerns unsafe dependency-management practices and the resulting avoidable supply-chain exposure. ### Attack Path 1. A user or deployment pipeline executes `pip install -r requirements.txt`. 2. The package resolver selects any available versions that satisfy the open-ended `>=` constraints. 3. A newly published, compromised, or otherwise unsafe package version can be selected without a corresponding project change or security review. 4. Package installation code executes with the privileges of the user or build environment performing the installation. 5. Malicious installation behavior could access files, credentials, or build artifacts available to that environment. ### Impact ...[truncated 616 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
Findings (15)

Tp4

High
Category
MCP Tool Poisoning
Confidence
98% confidence
Finding

The skill description promises automatic nearby-hotel discovery and report generation, but the reported implementation does not actually perform that workflow and includes a non-functional auto-fetch path. This mismatch is dangerous because users and orchestrators may make trust and execution decisions based on false capability claims, leading to silent failures, misleading analysis, or unsafe assumptions about external data collection.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
92% confidence
Finding

The README presents all user-facing instructions in Chinese and does not indicate that the skill is region-specific or provide any opt-in for language selection. This can violate language/locale policy when users are not given a choice or informed of the restriction.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
88% confidence
Finding

The skill advertises executable behavior with file-writing capability but does not declare any tool scope such as permissions or allowed-tools. That creates an authorization and transparency gap: a host system or user cannot easily determine what the skill is permitted to do, increasing the risk of unintended file modification or abuse if the implementation writes reports or other artifacts.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The natural-language description and instructions are entirely in Chinese, with no indication that users may choose another language or that the skill is intentionally limited to a Chinese-speaking or region-specific audience. The policy requires flagging language or locale constraints when they are imposed without user opt-in or clear justification.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The manifest describes a skill that 'automatically searches nearby hotels' and generates a competitive analysis report. In this implementation, the CLI accepts manually provided competitors or imports them from Excel, while the '--auto-fetch' path only prints that API configuration is required and does not perform any search. This is a substantive mismatch between the advertised capability and the actual code behavior.

Content

No source excerpt is available for this finding.

Missing User Warnings

Low
Category
Not specified by scanner
Confidence
89% confidence
Finding

The skill description omits a clear warning that it may query an external map service API for nearby-hotel data. This is a transparency and privacy issue because users may not realize that their hotel name, location context, or usage patterns could be sent to a third party.

Content

No source excerpt is available for this finding.

Unpinned Dependencies

Low
Category
Supply Chain
Confidence
95% confidence
Finding

The dependency is specified with a lower bound only, which allows future installs to resolve to different versions over time. This weakens build reproducibility and can unintentionally introduce vulnerable or breaking releases into the skill's environment.

Content

Scanner excerpt · requirements.txt (reported line 1)May include surrounding context.

text
requests>=2.28.0
pandas>=1.5.0
openpyxl>=3.0.0
pyyaml>=6.0

Unverifiable Dependency: requests has 16 known advisory(ies) (CVE-2014-1830 (Exposure of Sensitive Information to an Unauthorized Actor in Requests); CVE-2024-47081 (Requests vulnerable to .netrc credentials leak via malicious URLs); CVE-2024-35195 (Requests `Session` object does not verify requests after making first request wi) +13 more), but the manifest does not pin a version, so it is unknown whether the installed release is affected

Low
Category
Supply Chain
Confidence
92% confidence
Finding

The manifest does not pin requests, so it is impossible to verify from this file whether deployment will use a version affected by known advisories. Because requests handles outbound HTTP traffic and may interact with credentials, ambiguity around its installed version creates avoidable supply-chain and runtime risk.

Content

No source excerpt is available for this finding.

Unpinned Dependencies

Low
Category
Supply Chain
Confidence
95% confidence
Finding

Using an unpinned pandas version means installations are not reproducible and may pull in newer releases with security or compatibility issues. In security-sensitive workflows, this increases supply-chain uncertainty even if no exploit is present in the file itself.

Content

Scanner excerpt · requirements.txt (reported line 2)May include surrounding context.

text
requests>=2.28.0
pandas>=1.5.0
openpyxl>=3.0.0
pyyaml>=6.0
argparse>=1.4.0

Unverifiable Dependency: pandas has 1 known advisory(ies) (CVE-2020-13091 (** DISPUTED ** pandas through 1.0.3 can unserialize and execute commands from an)), but the manifest does not pin a version, so it is unknown whether the installed release is affected

Low
Category
Supply Chain
Confidence
84% confidence
Finding

Because pandas is not pinned, the security posture of the installed environment cannot be validated from the manifest alone. This is a weaker issue than active vulnerable code, but it still undermines assurance and reproducibility.

Content

No source excerpt is available for this finding.

Unpinned Dependencies

Low
Category
Supply Chain
Confidence
95% confidence
Finding

An unpinned openpyxl dependency can resolve to different versions across environments, making it hard to verify whether known vulnerable releases are excluded. This is especially relevant for libraries that process complex file formats such as spreadsheets.

Content

Scanner excerpt · requirements.txt (reported line 3)May include surrounding context.

text
requests>=2.28.0
pandas>=1.5.0
openpyxl>=3.0.0
pyyaml>=6.0
argparse>=1.4.0

Unverifiable Dependency: openpyxl has 2 known advisory(ies) (CVE-2017-5992 (Improper Restriction of XML External Entity Reference in Openpyxl); CVE-2017-5992 (Openpyxl 2.4.1 resolves external entities by default, which allows remote attack)), but the manifest does not pin a version, so it is unknown whether the installed release is affected

Low
Category
Supply Chain
Confidence
90% confidence
Finding

The requirements file does not establish which openpyxl version will be installed, so known vulnerable historical releases cannot be ruled out. Since openpyxl processes spreadsheet content, inability to verify patch level is a meaningful but low-severity dependency management risk.

Content

No source excerpt is available for this finding.

Unpinned Dependencies

Low
Category
Supply Chain
Confidence
97% confidence
Finding

PyYAML has a history of unsafe deserialization issues, and leaving it unpinned makes it unclear which behavior and security fixes will be present at install time. In a skill ecosystem, YAML is commonly used for configuration, so version drift can materially increase risk if unsafe loading is used elsewhere in the project.

Content

Scanner excerpt · requirements.txt (reported line 4)May include surrounding context.

text
requests>=2.28.0
pandas>=1.5.0
openpyxl>=3.0.0
pyyaml>=6.0
argparse>=1.4.0

# Optional dependencies

Unverifiable Dependency: pyyaml has 8 known advisory(ies) (CVE-2019-20477 (Deserialization of Untrusted Data in PyYAML); CVE-2020-1747 (Improper Input Validation in PyYAML); CVE-2020-14343 (Improper Input Validation in PyYAML) +5 more), but the manifest does not pin a version, so it is unknown whether the installed release is affected

Low
Category
Supply Chain
Confidence
96% confidence
Finding

PyYAML has multiple past advisories involving unsafe parsing behavior, and the unpinned manifest prevents confirmation that only patched versions will be installed. Given the common use of YAML for configuration in skills, this uncertainty is more concerning than for a purely auxiliary package.

Content

No source excerpt is available for this finding.

Unpinned Dependencies

Low
Category
Supply Chain
Confidence
50% confidence
Finding

Dependencies lack version pinning, allowing potential malicious package updates. Consider pinning versions.

Content

Scanner excerpt · requirements.txt (reported line 5)May include surrounding context.

text
pandas>=1.5.0
openpyxl>=3.0.0
pyyaml>=6.0
argparse>=1.4.0

# Optional dependencies
# scrapling>=1.0.0  # For OTA scraping (advanced mode)