T09 · Insecure Skill Coding Practices
- Location
SKILL.md:61- Finding
Feishu Secrets Are Collected Through Chat and Passed in Command-Line Arguments
- Content
View full analysis
' ``` ```bash python3 ~/.openclaw/workspace/skills/feishu-multi-agent-factory/scripts/setup_agents.py \ --config '' \ --restart ``` ### Technical Analysis The documented workflow asks users to provide a Feishu App Secret through an ordinary agent conversation. It then instructs the agent to place the complete secret-bearing JSON payload in the `--config` command-line argument. The script masks the secret in its normal output, but output masking does not protect the original input. The full secret may remain in: - Agent conversation history and associated telemetry - Process command-line arguments visible through local process inspection - Shell history if the documented command is executed manually - Automation logs, command traces, or error reports - Audit records maintained by the platform executing the command The alternative `--config-file` option exists in the implementation, but the primary documented procedure uses `--config` and does not require restrictive permissions for a secret-bearing file. ### Attack Path 1. A user supplies a valid Feishu App Secret through the documented conversation workflow. 2. The agent constructs an inline JSON payload containing the complete secret. 3. The payload is passed to `setup_agents.py` through the `--config` process argument. 4. An attacker with access to conversation records, shell history, pr ...[truncated 856 chars]- Remediation
View remediation
