Back to skill

Security audit

Doi Search

Security checks for vulnerabilities and agentic risk

Overview

The skill has a coherent DOI lookup purpose, but its shell command examples can unsafely place user-provided DOI text into curl commands.

Review before installing. The skill's DOI and Crossref lookups are appropriate, but it should validate DOI values, percent-encode path components, and avoid constructing shell command strings from user input before being used in an agent that executes commands.

Vulnerability Patterns
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)

T09 · Insecure Skill Coding Practices

Error
Location
SKILL.md:16
Finding

Potential Shell Command Injection Through Unsafely Interpolated DOI Input

Content
View full analysis
"`. 2. Use a página resolvida para identificar título, autores, publicação, editora/periódico, ano, URL canônica e acesso ao texto quando disponível. 3. Se o DOI não for informado, mas o usuário pedir para localizar uma obra, pesquise na Crossref REST API: `curl -sG "https://api.crossref.org/works" --data-urlencode "query=" --data-urlencode "rows=5"`. 4. Para candidatos Crossref, priorize correspondência por título, autores, ano, tipo (`journal-article`, `book`, `book-chapter`, etc.) e fonte. 5. Quando encontrar o DOI provável, confirme os metadados em: `curl -sL "https://api.crossref.org/works/"`. ``` ### Technical Analysis The skill directs the agent to place a DOI originating from the user directly inside a double-quoted shell command. It requires the DOI to be “normalized,” but it does not define strict validation, reject shell metacharacters, require URL encoding, or prohibit execution through a shell. Double quotes do not make arbitrary interpolation safe when the interpolated value can itself contain a quote. A crafted value containing a closing quote and shell control syntax could terminate the URL argument and introduce additional shell commands. Both the DOI.org resolution command and the Crossref metadata-confirmation command use this unsafe construction pattern. The Crossref search example uses `--data-urlencode` for search terms, which reduces URL-encoding problems, but the DOI path parameters are still directly interpolated into command text. ### Attack Path 1. An attacker asks the agent to resolve or verify a purported DOI. 2. The supplied DOI contains a double quote followed by shell contr ...[truncated 1449 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
Findings (4)

Skill Enumeration

Medium
Category
Agent Snooping
Confidence
80% confidence
Finding

Skill enumerates or reads other installed skills. Access to other skills' SKILL.md files or the skills directory reveals prompt instructions, capabilities, and secrets that should be invisible to peer skills.

Content

Scanner excerpt · SKILL.md (reported line 9)May include surrounding context.

md
---
# DOI Search

Location: `/skills/doi-search/SKILL.md` from the OpenClaw workspace root.

Use este skill quando o usuário pedir informações bibliográficas, metadados,
links ou confirmação de DOI de artigos, capítulos ou livros.

External Transmission

Medium
Category
Data Exfiltration
Confidence
50% confidence
Finding

Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.

Content

Scanner excerpt · SKILL.md (reported line 25)May include surrounding context.

md
editora/periódico, ano, URL canônica e acesso ao texto quando disponível.
3. Se o DOI não for informado, mas o usuário pedir para localizar uma obra,
   pesquise na Crossref REST API:
   `curl -sG "https://api.crossref.org/works" --data-urlencode "query=<termos>" --data-urlencode "rows=5"`.
4. Para candidatos Crossref, priorize correspondência por título, autores,
   ano, tipo (`journal-article`, `book`, `book-chapter`, etc.) e fonte.
5. Quando encontrar o DOI provável, confirme os metadados em:

External Transmission

Medium
Category
Data Exfiltration
Confidence
50% confidence
Finding

Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.

Content

Scanner excerpt · SKILL.md (reported line 29)May include surrounding context.

md
editora/periódico, ano, URL canônica e acesso ao texto quando disponível.
3. Se o DOI não for informado, mas o usuário pedir para localizar uma obra,
   pesquise na Crossref REST API:
   `curl -sG "https://api.crossref.org/works" --data-urlencode "query=<termos>" --data-urlencode "rows=5"`.
4. Para candidatos Crossref, priorize correspondência por título, autores,
   ano, tipo (`journal-article`, `book`, `book-chapter`, etc.) e fonte.
5. Quando encontrar o DOI provável, confirme os metadados em:

External Transmission

Medium
Category
Data Exfiltration
Confidence
50% confidence
Finding

Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.

Content

Scanner excerpt · SKILL.md (reported line 35)May include surrounding context.

md
editora/periódico, ano, URL canônica e acesso ao texto quando disponível.
3. Se o DOI não for informado, mas o usuário pedir para localizar uma obra,
   pesquise na Crossref REST API:
   `curl -sG "https://api.crossref.org/works" --data-urlencode "query=<termos>" --data-urlencode "rows=5"`.
4. Para candidatos Crossref, priorize correspondência por título, autores,
   ano, tipo (`journal-article`, `book`, `book-chapter`, etc.) e fonte.
5. Quando encontrar o DOI provável, confirme os metadados em: