T09 · Insecure Skill Coding Practices
- Location
references/jishudb-setup/scripts/install-windows.js:1860- Finding
Installation Execution Does Not Enforce the Documented User-Approval Gate
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md:51-64references/jishudb-setup/references/setup-quickstart.md:45-66references/jishudb-setup/scripts/install-windows.js:1860-1930references/jishudb-setup/scripts/install-macos.sh:1272-1300
Vulnerability Type: Missing execution-time authorization enforcement for persistent software installation
Risk Level: MediumRelevant Code and Instructions
The Skill requires user confirmation when prior installation authorization is absent:
markdown Treat `plan_ready` as internal progress. Reuse existing explicit installation or setup authorization when it covers the concrete transaction... If authorization is missing, ask one short confirmation after the plan is ready.The quickstart repeats that requirement but implements it only as an Agent instruction:
markdown On `plan_ready`, match the transaction to existing explicit user setup authorization. When covered, state a short progress update and continue. Otherwise ask one brief confirmation for the concrete installation. Never fabricate authorization from the ready status.On Windows, possession of the generated plan path and digest is sufficient to reach silent installer execution:
javascript async function runExecute(args, context) { assertReleaseSourceAvailable(args.releaseSource); const loaded = await loadApprovedPlan(args, context); const { plan, resolvedPlan, transactionRoot, source, nativeBytes, nativeSha256 } = loaded; // ... const installer = childProcess.spawnSync(installerPath, [ '/S', `/JISHUDB_AGENT_PLAN=${nativePlanPath}`, `/JISHUDB_AGENT_PLAN_SHA256=${nativeSha256 ?? args.planSha256}`, ], { env: sanitizedChildEnvironment(), stdio: 'ignore', windowsHide: false, shell: false, }); if (installer.error) throw installer.error; if (installer.status !== 0) fail('installer_failed', `Windows ...[truncated 3754 chars]- Remediation
View remediation
Remediation Suggestions
Enforce authorization in the executable path rather than relying exclusively on Agent instructions:
- Introduce a one-use approval receipt issued only after explicit user confirmation.
- Bind the receipt cryptographically or through a protected host authorization service to:
- The exact plan SHA-256.
- The operation type.
- Release version and installer digest.
- Installation and data paths.
- Current OS user identity.
- Client configuration target.
- Expiration time.
- Require the receipt in both Windows and macOS
executemodes and reject execution when it is missing, expired, already consumed, or inconsistent with the plan. - Keep
planand boundeddownloadread-only with respect to product installation, but require fresh consent evidence immediately before the first persistent mutation. - If a protected host approval mechanism is unavailable, add an unavoidable interactive confirmation that displays the concrete version, source, paths, operation, and launch behavior.
- Preserve existing integrity controls; do not replace plan hashes, catalog signatures, destination checks, or platform signature validation with the consent mechanism.
- Add negative tests proving that direct
executecalls fail without authorization and that approval for one plan cannot authorize a changed, renewed, or replacement plan.
