T09 · Insecure Skill Coding Practices
- Location
alibaba_super_resolve.py:288- Finding
Alibaba Cloud Access Key Secret Accepted Through Command-Line Arguments
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill does what it claims, but it handles cloud credentials and remote video processing in ways users should review before installing.
Review this skill before installing if your videos are private, regulated, or customer-owned: normal use sends the video to Alibaba Cloud for processing. Use least-privilege Alibaba RAM credentials, prefer environment variables or a managed credential provider instead of --access-key-secret, avoid running it in privileged environments, and consider pinning dependencies before deployment.
alibaba_super_resolve.py:288Alibaba Cloud Access Key Secret Accepted Through Command-Line Arguments
alibaba_super_resolve.py:173Unrestricted Download of a Remote API-Supplied URL
requirements.txt:1Unbounded Dependency Versions Permit Unreviewed Future Releases
The README explicitly promotes local file upload and cloud-based video enhancement, but it does not clearly disclose that user video content will be transmitted to and processed by Alibaba Cloud. This is a real privacy/transparency issue because users may upload sensitive or regulated media without informed consent about third-party processing and retention implications.
The skill documents use of environment variables for cloud credentials, performs network access to Alibaba Cloud, and writes output files, but it does not declare any explicit tool scope such as permissions or allowed-tools. This creates a least-privilege and transparency problem: an agent or reviewer cannot easily tell in advance that the skill can access secrets, contact external services, and write files, increasing the risk of unintended secret exposure or unsafe execution in broader environments.
The tool sends the full input video to Alibaba Cloud for processing, but it does not provide an explicit privacy/security warning or require affirmative user consent at the point of upload. In an agent skill context, users may assume processing is local; this can cause unintended disclosure of sensitive media, metadata, or regulated content to a third-party cloud service.
The natural-language instructions throughout the README are Chinese-only, which can amount to a language/locale policy issue when no user language choice or explicit region-specific limitation is provided. There is no statement that the skill is intended only for Chinese-speaking users or a specific regulated locale.
The dependency specification uses a lower-bound only constraint for requests, which makes builds non-reproducible and can pull in unexpected future versions or vulnerable intermediary versions depending on the resolver state. Because requests has a history of security advisories, leaving it unpinned increases supply-chain risk and makes it difficult to verify whether a deployed version is safe.
requests>=2.31.0
alibabacloud_tea_openapi>=0.3.0
alibabacloud_tea_util>=0.3.0
alibabacloud_videoenhan20200320>=1.1.0
The manifest includes requests without an exact version, and requests has multiple known advisories across its release history. Without pinning, there is no reliable way to determine whether an installation will pull a patched or vulnerable version, so the dependency remains unverifiable from a security standpoint.
The alibabacloud_tea_openapi package is specified with only a minimum version, so installations may resolve to different versions over time. This weakens build integrity and can introduce vulnerable or incompatible releases without code changes, which is a supply-chain security concern.
requests>=2.31.0
alibabacloud_tea_openapi>=0.3.0
alibabacloud_tea_util>=0.3.0
alibabacloud_videoenhan20200320>=1.1.0
The alibabacloud_tea_util dependency is unpinned, which permits uncontrolled version drift across environments. Even absent a known active CVE here, this creates preventable supply-chain exposure and undermines reproducibility for a skill that depends on cloud SDK behavior.
requests>=2.31.0
alibabacloud_tea_openapi>=0.3.0
alibabacloud_tea_util>=0.3.0
alibabacloud_videoenhan20200320>=1.1.0
The alibabacloud_videoenhan20200320 package is also declared with only a minimum version, allowing future unreviewed releases to be installed. For a cloud API integration, unexpected SDK changes can affect authentication, request handling, or security behavior, making this a legitimate though low-severity supply-chain issue.
requests>=2.31.0
alibabacloud_tea_openapi>=0.3.0
alibabacloud_tea_util>=0.3.0
alibabacloud_videoenhan20200320>=1.1.0
No suspicious patterns detected.