other
- Location
scripts/generate_map.py:72- Finding
Contact addresses are disclosed to an external geocoding service
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill does what it says, but it can expose Odoo contact addresses and generated contact details to third-party map/geocoding services at significant scale.
Install only if you are comfortable giving the skill read access to Odoo contacts and sending contact address data to external geocoding/map services. Prefer a read-only Odoo API key, avoid storing credentials in a skill-local .env for shared or backed-up workspaces, and consider using stored coordinates, an approved internal geocoder, bundled Leaflet assets, or SRI before using it with sensitive contacts.
scripts/generate_map.py:72Contact addresses are disclosed to an external geocoding service
scripts/generate_map.py:119Generated map executes CDN-hosted JavaScript without integrity verification
The documented fallback to a local .env file means the skill is designed to load Odoo credentials from plaintext material in the skill folder. Even though the text warns not to commit secrets, this pattern increases the chance of credential exposure through accidental commits, local file disclosure, backups, or overly broad workspace access.
- The skill declares trigger phrases so OpenClaw can surface it when you ask to see contacts on a map. If you want this to be the *default* handler for that UI action, I can enable the builtin mapping in OpenClaw config (requires confirmation).
Security
- Do not commit ODOO passwords or API keys. The script reads the environment first and falls back to a local .env in the skill folder if present.
Files
- scripts/generate_map.py — main generator script.
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Usage:
python3 generate_map.py [--city CITY]
The script reads ODOO_* from environment or a .env file next to the script.
"""
import xmlrpc.client, os, sys, time, argparse, requests, html
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Usage:
python3 generate_map.py [--city CITY]
The script reads ODOO_* from environment or a .env file next to the script.
"""
import xmlrpc.client, os, sys, time, argparse, requests, html
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Usage:
python3 generate_map.py [--city CITY]
The script reads ODOO_* from environment or a .env file next to the script.
"""
import xmlrpc.client, os, sys, time, argparse, requests, html
Code enumerates, copies, or searches environment variables for secrets. Bulk environment access can collect credentials unrelated to the skill's stated purpose.
def get_config():
# prefer process env, then .env in skill folder
cfg = dict(os.environ)
skill_env = os.path.join(os.path.dirname(__file__), '..', '.env')
cfg.update({k:v for k,v in load_env(skill_env).items() if k not in cfg})
return cfg
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
def get_config():
# prefer process env, then .env in skill folder
cfg = dict(os.environ)
skill_env = os.path.join(os.path.dirname(__file__), '..', '.env')
cfg.update({k:v for k,v in load_env(skill_env).items() if k not in cfg})
return cfg
The README proposes registering this skill as the default handler for the broad phrase "show contacts on map," which is common natural language a user might say in many contexts. Overly broad routing can cause unintended invocation of this skill, exposing contact data or triggering map generation when the user did not explicitly intend to use this particular skill.
The skill advertises capabilities that access environment secrets, write files, and use the network, but it does not declare an explicit permission or allowed-tools scope. That weakens reviewability and runtime containment, making it easier for a user or orchestrator to invoke a skill with broader access than expected.
The skill states that it geocodes contact addresses via Nominatim, but it does not clearly warn that contact location data may be transmitted to an external third-party service. Because the data concerns Odoo contacts, this can expose personal or business address information and create privacy, compliance, and confidentiality risks.
The script sends contact address data to the external Nominatim geocoding service for any record lacking coordinates, which discloses potentially sensitive customer or business location information to a third party. In this skill context, the data being mapped comes from Odoo contacts, so the privacy risk is directly tied to personal or confidential business records rather than generic public data.
The skill is described as generating an interactive map of Odoo contacts, but the implementation also harvests configuration from all environment variables and a sibling .env file. While Odoo authentication is expected for this purpose, broad environment ingestion is not itself part of the user-facing map capability and introduces access to potentially unrelated secrets.