T09 · Insecure Skill Coding Practices
- Location
SKILL.md:168- Finding
Security findings may be disclosed through PR comments without an explicit publication approval gate
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md:168-175
Vulnerability Type: External disclosure of sensitive audit results
Risk Level: MediumVulnerable Code
markdown - Executive summary (SSDF practice coverage, CWE distribution) - Findings table grouped by severity - Per-finding detail: detection signal, citation, proposal, status - Disposition table (applied / filed / deferred / rejected) - Re-run instructions If running inside a PR context, post the executive summary as a comment via `abstract:post_review_insights`.Technical Analysis
The Skill instructs the Agent to post a security-audit executive summary to a pull request whenever it detects a PR context. It does not require explicit user approval immediately before publication, display the exact outbound content, verify the destination repository and its visibility, or redact sensitive vulnerability information.
The hardening report can contain CWE classifications, severity levels, vulnerable file paths, detection signals, remediation status, and references to credential leaks. Even an executive summary can provide actionable information about unresolved weaknesses. Publishing this information is not necessary for the Skill's core local auditing and reporting functionality and therefore exceeds minimum privilege unless the user explicitly opts in.
The referenced
abstract:post_review_insightsimplementation is not included in this artifact, so its authentication, destination validation, and redaction behavior could not be verified. No evidence was found that the Skill directly transmits credentials or file contents through the patterns flagged inmodules/cross-cutting.md,modules/python-checks.md, ormodules/nist-controls.md; those matches are detector documentation and citation data.Attack Path
- The Skill audits a repository in a pull-request context.
- The audit identifies an unresolved vulnerability, credential exposure, or sensitive file path.
...[truncated 1496 chars]
- Remediation
View remediation
Remediation Suggestions
- Make all external posting explicitly opt-in, such as through a
--post-summaryoption that defaults to disabled. - Require an interactive approval immediately before transmission, regardless of other auto-apply settings.
- Display the exact destination, repository visibility, and complete outbound payload to the user before approval.
- Generate a redacted publication summary that excludes secrets, exploit details, vulnerable code snippets, sensitive paths, and active credential indicators.
- Post only after critical and high-severity findings have been remediated or the user explicitly accepts the disclosure risk.
- Validate that
abstract:post_review_insightstargets the intended repository and pull request and uses minimum API permissions. - Record publication consent and the posted content in the local audit report without storing credentials.
- Replace the current instruction with language such as:
markdown If running inside a PR context, offer to post a redacted executive summary. Do not invoke any external posting integration until the user reviews the exact payload and explicitly approves its destination. Never include secrets, exploit details, or sensitive file contents.- Make all external posting explicitly opt-in, such as through a
