T09 · Insecure Skill Coding Practices
- Location
SKILL.md:25- Finding
Hard-Coded Untrusted Network Proxy Configuration
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md, lines 25–29
Vulnerability Type:T09: Insecure Skill Coding Practices
Risk Level: MediumComplete Code Snippet:
markdown 1. 设置代理(如需要): ```bash export HTTP_PROXY=http://192.168.110.9:7890 export HTTPS_PROXY=http://192.168.110.9:7890 ```Technical Analysis
The skill instructs the operator or agent to configure both HTTP and HTTPS traffic to use the hard-coded proxy endpoint
192.168.110.9:7890. The documentation does not establish the proxy's owner, authorization status, integrity, or intended trust boundary.Because the variables are exported into the shell environment, they may affect not only the intended news-fetching commands but also subsequent network-aware processes launched from the same environment. The proxy can observe HTTP traffic and modify plaintext responses. For HTTPS traffic, it can observe connection metadata and could intercept or alter content if the environment trusts a certificate controlled by the proxy operator.
The proxy step is described as optional, which reduces exploitability, but no validation or user-approval procedure is specified.
Attack Path
- A user or agent follows the documented execution procedure and exports the proxy variables.
- The news-fetching scripts inherit
HTTP_PROXYandHTTPS_PROXY. - Their outbound requests are routed through
192.168.110.9:7890. - An operator controlling or compromising that proxy observes traffic or modifies responses.
- Manipulated news data is processed as trusted input and incorporated into the generated report.
- If the exported variables remain active, other network commands in the same shell may also use the proxy.
Impact Assessment
This issue does not directly grant local operating-system privileges. Its scope is the confidentiality and integrity of network traffic routed through the configured proxy. An attacker controllin ...[truncated 271 chars]
- Remediation
View remediation
Remediation Suggestions
- Remove the hard-coded proxy address from the skill instructions.
- Require the proxy endpoint to be supplied through an explicit, user-approved configuration mechanism.
- Document the proxy's trust requirements and require an authenticated, organization-controlled service.
- Apply proxy variables only to the individual commands that require them rather than exporting them globally:
bash HTTP_PROXY="$APPROVED_PROXY" HTTPS_PROXY="$APPROVED_PROXY" \ python3 scripts/fetch_news.py --source hackernews,weibo,v2ex --limit 15 - Prefer a TLS-protected proxy where supported and preserve strict destination TLS certificate validation.
- Do not install or trust interception certificate authorities unless explicitly authorized by the system owner.
- Clear inherited proxy variables after execution and ensure unrelated commands do not reuse them.
