T08 · Insecure Dependencies
Warning
- Location
- README_EN.md:148
- Finding
- Unpinned Third-Party Payment Skill Installation<![CDATA[ ## Vulnerability Details **File Location**: `README_EN.md:148-155` **Additional Locations**: `README.md:148-155`, `SKILL.md:89-96` **Vulnerability Type**: Unpinned and mutable third-party dependency installation **Risk Level**: Medium ### Vulnerable Code Snippet ```text Use the latest `okx-agent-payments-protocol` skill. The newer OKX payment skill supports both Agent Payments Protocol / x402 proof-based payment and the new `charge` payment method; follow the payment method returned or required by the OKX skill. # Install OKX Onchain OS skills npx skills add okx/onchainos-skills # Log in to the wallet for Agent Payments Protocol / x402 signing onchainos wallet login ``` ### Technical Analysis The installation instructions invoke `npx skills add okx/onchainos-skills` without specifying an immutable package version, reviewed commit, integrity hash, or cryptographic signature. The instructions additionally require the “latest” payment skill, meaning the dependency executed by users may differ from the version considered during this audit. This Skill does not itself contain malicious executable code. The risk arises at the supply-chain boundary: an upstream account compromise, malicious future release, package replacement, or compromised transitive dependency could introduce attacker-controlled behavior after this package has been reviewed. The dependency is particularly sensitive because it is subsequently used for wallet login, payment authorization, x402 proof generation, and charge processing. Executing mutable third-party components in that context increases the consequences of a supply-chain compromise. ### Attack Path 1. An attacker compromises the upstream package publisher, source repository, distribution channel, or one of its executable dependencies. 2. The attacker publishes a modified release under the package reference used by the installation command. 3. A user follows the documented `npx skills add okx/onchainos-skills` instru ...[truncated 1250 chars]
- Remediation
- <![CDATA[ ## Remediation Suggestions 1. Pin the external payment skill to a reviewed release version or immutable commit. 2. Provide and verify a cryptographic checksum, package signature, or lockfile before installation. 3. Document the expected publisher identity and official distribution channel. 4. Avoid instructing users to install the “latest” release automatically; require explicit review before upgrades. 5. Run the installer and payment helper with the minimum filesystem, environment, and network permissions required. 6. Keep API keys, private keys, seed phrases, and unrelated credentials unavailable to the dependency process. 7. Display and independently verify payment network, token, recipient, and amount immediately before authorization. 8. Document a tested compatibility matrix so users can remain on an audited version rather than automatically upgrading. ]]>
