T09 · Insecure Skill Coding Practices
- Location
SKILL.md:71- Finding
Unrestricted Caller-Controlled Output Directory and Broad Archival Operation
- Content
View full analysis
/.archive-/` first, then start fresh. ``` From `references/failure-modes.md`: ```markdown **Rule:** before writing anything to `output_dir`, check whether it already contains `plan.md` or `report.md`. - **If it does and `refresh` is not `true`:** refuse with a message naming the existing folder. - **If it does and `refresh: true`:** move the existing contents to `/.archive-/` first, then proceed with a fresh run. The archive preserves the audit trail. - **If it does not:** proceed normally. ``` ### Technical Analysis The Skill accepts any absolute path and explicitly directs the Agent to use it verbatim. It does not require path canonicalization, workspace confinement, ownership validation, symlink rejection, or confirmation that the target is a directory created and owned by this Skill. The `refresh: true` workflow increases the risk because it directs the Agent to move the directory's “existing contents,” rather than limiting the operation to kno ...[truncated 1887 chars]- Remediation
View remediation
