T09 · Insecure Skill Coding Practices
- Location
index.ts:76- Finding
ACP Request Parameters Are Not Validated
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill appears to be a legitimate IDE-to-agent bridge, but it needs review because it can pass prompts and session history to a gateway while its implementation lacks strong validation and session isolation.
Review before installing or using with confidential workspaces. Use it only with a trusted local OpenClaw gateway, and require stronger input validation, cryptographically secure session IDs, caller authorization, and clear session-history retention/deletion controls before production use.
index.ts:76ACP Request Parameters Are Not Validated
index.ts:103Predictable Session Identifiers Without Client Authorization Binding
The skill explicitly describes forwarding ACP prompts, session state, and session history through an OpenClaw gateway, including session/history retrieval and WebSocket transport, but it does not warn users that potentially sensitive prompts and histories leave the immediate IDE context. In an IDE integration skill, this omission can cause inadvertent disclosure of source code, secrets, or proprietary context because users may assume interactions remain local unless clearly told otherwise.
The skill design includes creation of factory sessions and loading/replaying ASF session history, indicating persistent session state across ACP tasks without any documented retention limits, consent flow, or data minimization guarantees. In a multi-agent IDE bridge, persistent sessions can accumulate sensitive code, prompts, and tool outputs, increasing exposure if accessed by other components, replayed unexpectedly, or retained longer than intended.
interface AgenticFactoryIntegration {
// Create factory session for ACP task
createFactoryForACP(acpSession: ACPSession): Promise<FactorySession>;
// Route ACP prompt to factory
The inline comment says the real behavior would route the prompt to an ASF agent, indicating actual forwarding/integration behavior. However, the code below does not perform any routing or gateway use and instead returns a hardcoded placeholder response, which directly contradicts the documented intent of this handler.