T09 · Insecure Skill Coding Practices
Warning
- Location
scripts/media_gen_client.py:84- Finding
Unrestricted Download of a Server-Supplied URL
- Content
View full analysis
Dict[str, Any]: """ Download a (possibly signed) URL to local file. Designed for OSS signed URLs returned by video generation tasks. """ os.makedirs(os.path.dirname(out_path) or ".", exist_ok=True) req = urllib.request.Request(url, headers={"User-Agent": "OpenClaw-Media-Gen/1.0"}) try: with urllib.request.urlopen(req, timeout=timeout_s) as resp, open(out_path, "wb") as f: total = 0 while True: chunk = resp.read(1024 * 1024) # 1MB if not chunk: break f.write(chunk) total += len(chunk) return {"success": True, "saved_to": out_path, "bytes": total} except Exception as e: return {"success": False, "error": str(e), "url": url, "saved_to": out_path} ``` The download is initiated using a URL taken directly from the task-status response: ```python if status == "SUCCEEDED" and getattr(args, "download", False): video_url = (resp.get("output") or {}).get("video_url") or (resp.get("output") or {}).get("videoUrl") if video_url: out_path = args.out or _safe_filename("mp4") dl = _download_to_file(video_url, out_path) resp = {**resp, "download": dl} ``` ### Technical Analysis The client trusts `video_url` returned by the remote AIsa API and passes it directly to `urllib.request.urlopen`. It does not validate: - The URL scheme, such as requiring HTTPS. - Whether the destination belongs to an expected media-storage domain. - Whether the destination resolves to a loopback, private, link-local, or otherwise sensitive address. - Redirect destinations. - The response content t ...[truncated 2115 chars]- Remediation
View remediation