Back to skill

Security audit

knowledge-card-generator

Security checks for vulnerabilities and agentic risk

Overview

The skill matches its image-generator purpose, but it needs review because it sends user content to third-party services and recommends running an unpinned npm CLI with an API key exposed.

Review before installing. Prefer the documented curl/API path or a pinned, verified OneKey CLI version over unversioned `npx onekey`; use a low-privilege, revocable API key; and avoid sending secrets, regulated data, private images, or sensitive prompts unless you trust the DeepNLP/Craftsman service and understand who can access share URLs.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)

T08 · Insecure Dependencies

Warning
Location
SKILL.md:561
Finding

Unpinned npm Package Execution Through npx

Content
View full analysis

Vulnerability Details

File Location: SKILL.md, line 561
Vulnerability Type: Unpinned third-party package execution
Risk Level: Medium

Vulnerable Code

bash
export DEEPNLP_ONEKEY_ROUTER_ACCESS=your_access_key
npx onekey agent craftsman-agent/craftsman-agent image_generator '{"prompt":"Introduction to Difference between MCPs,Skills and Agents CLIs","images":[],"card_count":1,"template_id":"knowledge-card","api_id":"image_generator","asset_size":[{"width":1080,"height":1080,"ratio":"1:1"}],"mode":"basic","session_id":"31d57eb9-9a37-4808-9c5b-1bfbb2abf5fb","session_name":"AI Poster of MCPs/CLIs/Agents","tag_list":"","model":"default","styles":["Editorial grid layout with corporate dark deep monochromatic tones"],"design_config":{"template_id":"knowledge-card","card_count":1,"card_count_source":"default","channel_profile":"generic","audience_profile":"general","age_band":"auto","profile_version":"1.0.0","geometry_source":"profile","resolved_profiles":[{"type":"channel","id":"generic","version":"1.0.0"},{"type":"audience","id":"general","version":"1.0.0"}],"language":"auto","mode":"standard","text_model":"default","image_model":"default","styles":["Editorial grid layout with corporate dark deep monochromatic tones"],"constraints":["Limit target output build to 6 high-density pages max for physical double folding print"],"brief_inputs":[{"id":"binp-1","type":"prompt","content":"Introduction to Difference between MCPs,Skills and Agents CLIs"},{"id":"binp-2","type":"style","content":"Editorial grid layout with corporate dark deep monochromatic tones"},{"id":"binp-3","type":"constraint","content":"Limit target output build to 6 high-density pages max for physical double folding print"},{"id":"binp-1786857754660","type":"prompt","content":"Custom newly configured prompt parameter specifications instructions layout metric..."}],"text_styles":{"brand":{"color":"#8b5cf6","font":"Playfair Display","font_size":"20px","font_weight":"600","text_align":"l
...[truncated 3545 chars]
Remediation
View remediation

Remediation Suggestions

  1. Pin the CLI package to an exact, reviewed version:

    bash
    npx --yes onekey@X.Y.Z agent craftsman-agent/craftsman-agent image_generator '...'
    
  2. Verify the package's official name, publisher identity, provenance, and expected registry before recommending execution.

  3. Prefer installing the reviewed dependency locally with a committed lockfile and integrity metadata rather than downloading executable code on demand.

  4. Configure npm to use an explicitly trusted registry and enforce package integrity or provenance checks where supported.

  5. Run the CLI with least privilege in an isolated environment that exposes only the files and network access required for image generation.

  6. Provide the API key only to the final trusted process. Use a short-lived, narrowly scoped credential and rotate it if package compromise is suspected.

  7. Document the expected package checksum, version-update review process, and publisher so users can validate future upgrades.

Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Memory PoisoningPersistent Context Injection, Context Window Stuffing, Memory Manipulation
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
Findings (15)

External Transmission

Medium
Category
Data Exfiltration
Confidence
88% confidence
Finding

The documented workflow sends user-controlled content and an access key to an external service at agent.deepnlp.org, which is a genuine external transmission boundary. In this skill's context that behavior is expected, but it still creates a real privacy and data-exposure risk because prompts, images, and rich metadata leave the local environment and are processed by a remote third party.

Content

Scanner excerpt · SKILL.md (reported line 44)May include surrounding context.

bash
export DEEPNLP_ONEKEY_ROUTER_ACCESS=your_access_key

curl -X POST "https://agent.deepnlp.org/agent_router" \
-H "Content-Type: application/json" \
-H "X-OneKey: $DEEPNLP_ONEKEY_ROUTER_ACCESS" \
-d '{

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The skill explicitly instructs users to send prompts, images, and detailed design configuration to third-party endpoints and later exposes resulting content through a shareable workspace URL, but it does not warn users about that data flow. This can lead to inadvertent disclosure of sensitive prompts, uploaded images, or generated artifacts to external services or anyone with the share link.

Content

No source excerpt is available for this finding.

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 89)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 91)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 92)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 93)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 94)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 95)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 96)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 97)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 98)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 99)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 101)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 102)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Context Window Stuffing

Medium
Category
Memory Poisoning
Confidence
80% confidence
Finding

Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.

Content

Scanner excerpt · SKILL.md (reported line 103)May include surrounding context.

md
### Design Config Layers AI Brief

| Field       | Description                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       |
|-------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| template_id | Template ID, supported values: ai-poster,social-media-carousel,presentation,app-store,icon-designer,logo-designer,photo-editor                                                                                                                                                                                                                                                                                                                                                                                                                    |
| card_count  | 4                                                                                                                                                                                                                                                                                                                
...[truncated 25 chars]

Static analysis

No suspicious patterns detected.